Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prdoc] Validate crate names #3467

Merged
merged 10 commits into from
Feb 26, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update version
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
ggwpez committed Feb 24, 2024
commit 903c210b35c5001c7e6db2f340ec3b8ba38bb6e2
3 changes: 1 addition & 2 deletions .github/scripts/check-prdoc.py
Original file line number Diff line number Diff line change
@@ -30,7 +30,7 @@ def check_prdoc_crate_names(root, paths):

print(f'πŸ”Ž Reading workspace {root}.')
workspace = cargo_workspace.Workspace.from_path(root)
crate_names = [crate.name() for crate in workspace.crates()]
crate_names = [crate.name for crate in workspace.crates]

print(f'πŸ“¦ Checking {len(paths)} prdocs against {len(crate_names)} crates.')
faulty = {}
@@ -66,7 +66,6 @@ def parse_args():

return { 'root': os.path.abspath(args.root[0]), 'prdocs': args.prdoc }


if __name__ == '__main__':
args = parse_args()
check_prdoc_crate_names(args['root'], args['prdocs'])
2 changes: 1 addition & 1 deletion .github/workflows/check-prdoc.yml
Original file line number Diff line number Diff line change
@@ -62,5 +62,5 @@ jobs:
if: ${{ !contains(steps.get-labels.outputs.labels, 'R0') }}
run: |
echo "Validating PR#${GITHUB_PR}"
python3 -m pip install cargo-workspace
python3 -m pip install cargo-workspace==1.1.0
python3 .github/scripts/check-prdoc.py Cargo.toml prdoc/pr_${GITHUB_PR}.prdoc