-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactors referenda pallet to use fungible traits #1785
Open
gpestana
wants to merge
13
commits into
master
Choose a base branch
from
gpestana/referenda-fungibles
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+162
−54
Open
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
41da34f
Refactors referenda pallet to use fungible traits
gpestana fe11b96
Adds the OnSlash handler back
gpestana 516631d
Add on slash handler back
gpestana 143c427
tests associated type for OnUnbalanced
gpestana 24840ed
Merge branch 'master' into gpestana/referenda-fungibles
gpestana 6493c28
fix
gpestana bbb1a04
updates treasury config
gpestana 4c2487d
Merge branch 'master' into gpestana/referenda-fungibles
gpestana fabee79
Merge branch 'master' into gpestana/referenda-fungibles
gpestana 2dfd8eb
updates runtimes
gpestana 440b9ff
Finishes FunOnUnbalanced implementation
gpestana 0352c9c
Merge branch 'master' into gpestana/referenda-fungibles
gpestana 14883bf
HoldReason compatible with instantiable pallets
gpestana File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Merge branch 'master' into gpestana/referenda-fungibles
commit 24840ed7703d64a903bcee313dd6b2c04fb9aeea
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You are viewing a condensed version of this merge commit. You can view the full changes here.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this fails then the credit is just dropped correctly, or?