Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bandersnatch-vrfs with locked dependencies ref #1342

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Use bandersnatch-vrfs with locked dependencies ref #1342

merged 3 commits into from
Sep 1, 2023

Conversation

davxy
Copy link
Member

@davxy davxy commented Aug 31, 2023 •
edited
Loading

Related to w3f/ring-vrf#57

Long term solution: release fflonk, ring-proof, bandersnatch-vrfs and co. on crates.io
(but only after RingProver/RingVerifier serialization support pls :-)

cc @burdges @swasilyev @jasl

@jasl
Copy link
Contributor

jasl commented Aug 31, 2023 •
edited
Loading

I tried this way, then cargo update -p bandersnatch_vrfs

Then I got

    Updating git repository `https://github.com/w3f/ring-vrf`
    Updating crates.io index
    Updating git repository `https://github.com/w3f/ring-vrf`
    Updating git repository `https://github.com/w3f/fflonk`
    Updating git repository `https://github.com/w3f/ring-proof`
error: failed to select a version for `ark-scale`.
    ... required by package `bandersnatch_vrfs v0.0.1 (https://github.com/w3f/ring-vrf?rev=3119f51#3119f51b)`
    ... which satisfies git dependency `bandersnatch_vrfs` of package `sp-core v21.0.0 (/Users/jasl/Workspaces/BlockChain/polkadot-sdk/substrate/primitives/core)`
    ... which satisfies path dependency `sp-core` (locked to 21.0.0) of package `asset-hub-kusama-integration-tests v1.0.0 (/Users/jasl/Workspaces/BlockChain/polkadot-sdk/cumulus/parachains/integration-tests/emulated/assets/asset-hub-kusama)`
versions that meet the requirements `*` (locked to 0.0.3) are: 0.0.3

the package `bandersnatch_vrfs` depends on `ark-scale`, with features: `ec` but `ark-scale` does not have these features.


failed to select a version for `ark-scale` which could resolve this conflict

Maybe I shouldn't do cargo update?

@davxy
Copy link
Member Author

davxy commented Aug 31, 2023

Try to cargo update -p ark-scale as well

@davxy davxy requested a review from a team August 31, 2023 18:06
@davxy davxy added the T0-node This PR/Issue is related to the topic “node”. label Aug 31, 2023
@jasl
Copy link
Contributor

jasl commented Aug 31, 2023

Try to cargo update -p ark-scale as well

jasl@bogon:~/Workspaces/BlockChain/polkadot-sdk on master$ git status
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   substrate/primitives/core/Cargo.toml

no changes added to commit (use "git add" and/or "git commit -a")
jasl@bogon:~/Workspaces/BlockChain/polkadot-sdk on master$ cargo update -p ark-scale
    Updating crates.io index
    Updating git repository `https://github.com/w3f/ring-vrf`
    Updating git repository `https://github.com/w3f/ring-proof`
      Adding ark-scale v0.0.10
      Adding ark-secret-scalar v0.0.2 (https://github.com/w3f/ring-vrf?rev=3119f51#3119f51b)
    Removing ark-secret-scalar v0.0.2 (https://github.com/w3f/ring-vrf?rev=c86ebd4#c86ebd41)
      Adding ark-transcript v0.0.2 (https://github.com/w3f/ring-vrf?rev=3119f51#3119f51b)
    Removing ark-transcript v0.0.2 (https://github.com/w3f/ring-vrf?rev=c86ebd4#c86ebd41)
      Adding bandersnatch_vrfs v0.0.1 (https://github.com/w3f/ring-vrf?rev=3119f51#3119f51b)
    Removing bandersnatch_vrfs v0.0.1 (https://github.com/w3f/ring-vrf?rev=c86ebd4#c86ebd41)
      Adding common v0.1.0 (https://github.com/w3f/ring-proof?rev=0e948f3#0e948f3c)
    Removing common v0.1.0 (https://github.com/w3f/ring-proof#0e948f3c)
      Adding dleq_vrf v0.0.2 (https://github.com/w3f/ring-vrf?rev=3119f51#3119f51b)
    Removing dleq_vrf v0.0.2 (https://github.com/w3f/ring-vrf?rev=c86ebd4#c86ebd41)
      Adding ring v0.1.0 (https://github.com/w3f/ring-proof?rev=0e948f3#0e948f3c)
    Removing ring v0.1.0 (https://github.com/w3f/ring-proof#0e948f3c)
jasl@bogon:~/Workspaces/BlockChain/polkadot-sdk on master$ cargo update -p bandersnatch_vrfs
    Updating git repository `https://github.com/w3f/ring-vrf`
    Updating crates.io index
    Updating git repository `https://github.com/w3f/fflonk`
    Updating git repository `https://github.com/w3f/ring-proof`
error: failed to select a version for `ark-scale`.
    ... required by package `bandersnatch_vrfs v0.0.1 (https://github.com/w3f/ring-vrf?rev=3119f51#3119f51b)`
    ... which satisfies git dependency `bandersnatch_vrfs` of package `sp-core v21.0.0 (/Users/jasl/Workspaces/BlockChain/polkadot-sdk/substrate/primitives/core)`
    ... which satisfies path dependency `sp-core` (locked to 21.0.0) of package `asset-hub-kusama-integration-tests v1.0.0 (/Users/jasl/Workspaces/BlockChain/polkadot-sdk/cumulus/parachains/integration-tests/emulated/assets/asset-hub-kusama)`
versions that meet the requirements `*` (locked to 0.0.3) are: 0.0.3

the package `bandersnatch_vrfs` depends on `ark-scale`, with features: `ec` but `ark-scale` does not have these features.


failed to select a version for `ark-scale` which could resolve this conflict

@bkchr
Copy link
Member

bkchr commented Aug 31, 2023

@davxy do we maybe need to pin more deps?

@davxy davxy mentioned this pull request Sep 1, 2023
Merged
@davxy
Copy link
Member Author

davxy commented Sep 1, 2023

@jasl @bkchr should be fixed

@davxy davxy mentioned this pull request Sep 1, 2023
Closed
@davxy davxy requested a review from a team September 1, 2023 10:46
@jasl
Copy link
Contributor

jasl commented Sep 1, 2023

@jasl @bkchr should be fixed

thank you, hope this can be merged ASAP

@bkchr bkchr merged commit 0d6ef3e into master Sep 1, 2023
7 checks passed
@bkchr bkchr deleted the davxy-bandersnatch-vrfs-with-dependencies-refs branch September 1, 2023 13:58
ordian added a commit that referenced this pull request Sep 1, 2023
@ordian
Merge branch 'master' into s0me0ne/candidate-session-index
40e3da9 
* master: (25 commits)
  fix typos (#1339)
  Use bandersnatch-vrfs with locked dependencies ref (#1342)
  Bump bs58 from 0.4.0 to 0.5.0 (#1293)
  Contracts: `seal0::balance` should return the free balance (#1254)
  Logs: add extra debug log for negative rep changes (#1205)
  Added short-benchmarks for cumulus (#1183)
  [xcm-emulator] Improve hygiene and clean up (#1301)
  Bump the known_good_semver group with 1 update (#1347)
  Renames API (#1186)
  Rename `polkadot-parachain` to `polkadot-parachain-primitives` (#1334)
  Add README to project root (#1253)
  Add environmental variable to track decoded instructions (#1320)
  Fix polkadot-node-core-pvf-prepare-worker build with jemalloc (#1315)
  Sassafras primitives (#1249)
  Restructure `dispatch` macro related exports (#1162)
  backing: move the min votes threshold to the runtime (#1200)
  Bump zstd from 0.11.2+zstd.1.5.2 to 0.12.4 (#1326)
  Remove `substrate_test_utils::test` (#1321)
  remove disable-runtime-api (#1328)
  [ci] add more jobs for pipeline cancel, cleanup (#1314)
  ...
ordian added a commit that referenced this pull request Sep 7, 2023
@ordian
Merge branch 'master' into ao-polkadot-use-pinning-api
d3e00e0 
* master: (25 commits)
  Markdown linter (#1309)
  Update `fmt` file and some authors (#1379)
  Bump the known_good_semver group with 1 update (#1375)
  Bump proc-macro-warning from 0.4.1 to 0.4.2 (#1376)
  feat: add futures api to `TransactionPool` (#1348)
  Ensure cumulus/bridges is ignored by formatter and run it (#1369)
  substrate: chain-spec paths corrected in zombienet tests (#1362)
  contracts: Update to wasmi 0.31 (#1350)
  [improve docs]: Template pallet (#1280)
  [xcm-emulator] Unignore cumulus integration tests (#1247)
  Fix wrong ref counting (#1358)
  Use cached session index to obtain executor params (#1190)
  fix typos (#1339)
  Use bandersnatch-vrfs with locked dependencies ref (#1342)
  Bump bs58 from 0.4.0 to 0.5.0 (#1293)
  Contracts: `seal0::balance` should return the free balance (#1254)
  Logs: add extra debug log for negative rep changes (#1205)
  Added short-benchmarks for cumulus (#1183)
  [xcm-emulator] Improve hygiene and clean up (#1301)
  Bump the known_good_semver group with 1 update (#1347)
  ...
Daanvdplas pushed a commit that referenced this pull request Sep 11, 2023
@davxy @Daanvdplas
Use bandersnatch-vrfs with locked dependencies ref (#1342)
80badf2 
* Use bandersnatch-vrfs with locked dependencies ref

* Update ark-scale to 0.0.10

* Bump ark-substrate crates version
chrisdcosta added a commit to totem-tech/kapex-substrate that referenced this pull request Sep 20, 2023
@chrisdcosta
Fix issue with bandersnatch
a261d34 
Applied fixes from paritytech/polkadot-sdk#1342
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@davxy
Use bandersnatch-vrfs with locked dependencies ref (paritytech#1342)
7db568a 
* Use bandersnatch-vrfs with locked dependencies ref

* Update ark-scale to 0.0.10

* Bump ark-substrate crates version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkchr bkchr bkchr approved these changes

@skunert skunert skunert approved these changes

Assignees
No one assigned
Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davxy @jasl @bkchr @skunert