Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Approval-voting: Automatically schedule wakeups for unapproved candidates to 'unstick' them #949

Open
rphmeier opened this issue Sep 14, 2021 · 2 comments
Open

Approval-voting: Automatically schedule wakeups for unapproved candidates to 'unstick' them #949

rphmeier opened this issue Sep 14, 2021 · 2 comments
Assignees
@ordian @Lldenaurois
Labels
I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue.

Comments

@rphmeier
Copy link
Contributor

This is a failsafe that, in combination with paritytech/polkadot#3848 should ensure that no candidates get stuck for a significant period of time.
@Lldenaurois
Copy link

Proposal:

In .../approval-voting/lib.rs, we do not schedule a wakeup for blocks that are not our assignment and simply print "no assignment" and then continue as we loop over all unapproved candidates in the block_entry.

Log line: https://github.com/paritytech/polkadot/blob/master/node/core/approval-voting/src/lib.rs#L1308

It seems like at this particular point we should simply schedule a wakeup for the unapproved candidate.

@rphmeier
Copy link
Contributor Author

Exactly.

@Sophia-Gold Sophia-Gold transferred this issue from paritytech/polkadot Aug 24, 2023
@the-right-joyce the-right-joyce added I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue. and removed I4-annoyance labels Aug 25, 2023
claravanstaden pushed a commit to Snowfork/polkadot-sdk that referenced this issue Dec 8, 2023
@yrong @vgeddes
SNO-632: Submit outbound message with priority control (paritytech#949)
c05de23 
* Submit outbound message without MessageQueue

* Priority control

* Update priority

* Update cumulus

* Reserve space for high priority messages

* Fix compile error & More refactor

* Improve processing high priority messages

* Some polish

* Add priority back

* Improve comments

* Rename priority to normal

* Refactor submit logic

* Refactor process message

* Add type HighPriorityCommands

* Fix clippy

* Rename priority with BridgeHub

* Update parachain/primitives/core/src/outbound.rs

Co-authored-by: Vincent Geddes <[email protected]>

* Update parachain/pallets/outbound-queue/src/lib.rs

Co-authored-by: Vincent Geddes <[email protected]>

* Update parachain/pallets/outbound-queue/src/lib.rs

Co-authored-by: Vincent Geddes <[email protected]>

* Revamp with ExportOrigin

* Fix format

* Some polish

* Check weight before processing message (paritytech#974)

* update cumulus submodule

* Improve comments

* update cumulus

* Update cumulus

---------

Co-authored-by: Vincent Geddes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ordian ordian

@Lldenaurois Lldenaurois

Labels
I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ordian @rphmeier @Lldenaurois @the-right-joyce