Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fatxpool: improve event listeners #5495

Open
Tracked by #5472
michalkucharczyk opened this issue Aug 27, 2024 · 0 comments
Open
Tracked by #5472

fatxpool: improve event listeners #5495

michalkucharczyk opened this issue Aug 27, 2024 · 0 comments
Assignees
@michalkucharczyk
Labels
T0-node This PR/Issue is related to the topic “node”.

Comments

@michalkucharczyk
Copy link
Contributor

Some improvements can be made to internal eventing system:

  • update_view: InBlock event could be sent via side-channel, instead of registering listener in view (in case transaction is already in the cloned view). This can simplify the code.
  • TxInMemPool::watched - this could be replaced with listener, TxMemPool::listener would become redundant.
@michalkucharczyk michalkucharczyk self-assigned this Aug 27, 2024
@michalkucharczyk michalkucharczyk added the T0-node This PR/Issue is related to the topic “node”. label Aug 27, 2024
@michalkucharczyk michalkucharczyk mentioned this issue Aug 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michalkucharczyk michalkucharczyk

Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michalkucharczyk