Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rethink if we should tolerate a closed inbound Notifications substream #508

Open
dmitry-markin opened this issue May 8, 2023 · 0 comments
Open

Rethink if we should tolerate a closed inbound Notifications substream #508

dmitry-markin opened this issue May 8, 2023 · 0 comments
Labels
I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue.

Comments

@dmitry-markin
Copy link
Contributor

dmitry-markin commented May 8, 2023 •
edited
Loading

As commented here, we don't consider Notifications protocol disconnected if only the inbound substream is closed.

We should check if this feature is used by any protocol in Polkadot and change the behavior, which would simplify the detection of disconnected sync peers (relates to paritytech/substrate#13396) and reduce syncing stalling issues.

Also may be make this behavior configurable, requiring protocols to explicitly allow closed inbound substreams.

See also paritytech/substrate#13611 (comment).
@dmitry-markin dmitry-markin mentioned this issue May 8, 2023
Merged
@altonen altonen transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue. and removed I4-annoyance labels Aug 25, 2023
@altonen altonen mentioned this issue Sep 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue.
Projects
Networking
Status: Backlog 🗒
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmitry-markin @the-right-joyce