Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return peer info instead of Peerset::debug_info #507

Open
dmitry-markin opened this issue May 16, 2023 · 0 comments
Open

Return peer info instead of Peerset::debug_info #507

dmitry-markin opened this issue May 16, 2023 · 0 comments
Labels
I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue.

Comments

@dmitry-markin
Copy link
Contributor

dmitry-markin commented May 16, 2023 •
edited
Loading

This is a follow-up issue to paritytech/substrate#13611.

Originally, Peerset had centralized information on peer states, and this info was returned in Peerset::debug_info. This information was served as part of system_unstable_networkState RPC request.

Once paritytech/substrate#13611 is merged, the peer states are moved to ProtocolController instances, with PeerStore keeping the peer reputations.

This issue is to research if any valuable information can be returned from PeerStore or ProtocolController instead of Peerset::debug_info, or whether we should remove this call completely.
@altonen altonen transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue. and removed I4-annoyance labels Aug 25, 2023
bkchr pushed a commit that referenced this issue Apr 10, 2024
@dependabot-preview @tomusdrw @bkchr
Bump futures from 0.3.7 to 0.3.8 (#507)
be56ee5 
* Bump futures from 0.3.7 to 0.3.8

Bumps [futures](https://github.com/rust-lang/futures-rs) from 0.3.7 to 0.3.8.
- [Release notes](https://github.com/rust-lang/futures-rs/releases)
- [Changelog](https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md)
- [Commits](rust-lang/futures-rs@0.3.7...0.3.8)

Signed-off-by: dependabot-preview[bot] <[email protected]>

* Fix clippy.

* Fix more clippy.

* Fix clippy again?

* Cliipy yet again.

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Tomasz Drwięga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I3-annoyance The node behaves within expectations, however this “expected behaviour” itself is at issue.
Projects
Networking
Status: Backlog 🗒
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmitry-markin @the-right-joyce