Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FRAME] Deprecate old scheduler traits #3676

Closed
ggwpez opened this issue Mar 13, 2024 · 2 comments
Closed

[FRAME] Deprecate old scheduler traits #3676

ggwpez opened this issue Mar 13, 2024 · 2 comments
Assignees
@chungquantin
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. T13-deprecation The current issue/pr is, or should be, part of a deprecation process.

Comments

@ggwpez
Copy link
Member

ggwpez commented Mar 13, 2024

V1 and V2 scheduler traits in frame-support should be deprecated.
Follow up to #1142
@ggwpez ggwpez added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. T13-deprecation The current issue/pr is, or should be, part of a deprecation process. D1-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. labels Mar 13, 2024
@ggwpez ggwpez added D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. and removed D1-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase. labels Mar 13, 2024
@chungquantin chungquantin mentioned this issue Mar 17, 2024
Merged
@chungquantin
Copy link
Contributor

@ggwpez I have created a PR to add #[deprecated] attribute to the old versions of the trait. Let me know if it is good to go. Thanks

github-merge-queue bot pushed a commit that referenced this issue Mar 28, 2024
@chungquantin @ggwpez @liamaharon
Deprecate scheduler traits v1 and v2 (#3718)
daf04f0 
This PR add `#[deprecated]` attribute to v1 and v2 of the schedule
trait. Proposed in this issue:
#3676

```rust
#[allow(deprecated)]
#[deprecated = "traits::schedule::v1 is deprecated. Please use v3 instead."]
pub mod v1 {
...
}

#[allow(deprecated)]
#[deprecated = "traits::schedule::v2 is deprecated. Please use v3 instead."]
pub mod v2 {
...
}
```

polkadot address: 19nSqFQorfF2HxD3oBzWM3oCh4SaCRKWt1yvmgaPYGCo71J

---------

Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Liam Aharon <[email protected]>
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this issue Apr 9, 2024
@chungquantin @ggwpez
@liamaharon @dharjeezy
Deprecate scheduler traits v1 and v2 (paritytech#3718)
3569f0a 
This PR add `#[deprecated]` attribute to v1 and v2 of the schedule
trait. Proposed in this issue:
paritytech#3676

```rust
#[allow(deprecated)]
#[deprecated = "traits::schedule::v1 is deprecated. Please use v3 instead."]
pub mod v1 {
...
}

#[allow(deprecated)]
#[deprecated = "traits::schedule::v2 is deprecated. Please use v3 instead."]
pub mod v2 {
...
}
```

polkadot address: 19nSqFQorfF2HxD3oBzWM3oCh4SaCRKWt1yvmgaPYGCo71J

---------

Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Liam Aharon <[email protected]>
@Krayt78
Copy link
Contributor

Krayt78 commented Dec 8, 2024

@ggwpez i think this should be closed since #3718 fixed it

@ggwpez ggwpez closed this as completed Jan 3, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in Runtime / FRAME Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chungquantin chungquantin

Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. T13-deprecation The current issue/pr is, or should be, part of a deprecation process.
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ggwpez @Krayt78 @chungquantin