Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queried Preimage Hash returns unrequested while it was not. #3278

Closed
2 tasks done
dudo50 opened this issue Feb 9, 2024 · 3 comments
Closed
2 tasks done

Queried Preimage Hash returns unrequested while it was not. #3278

dudo50 opened this issue Feb 9, 2024 · 3 comments
Labels
I2-bug The node fails to follow expected behavior. I10-unconfirmed Issue might be valid, but it's not yet known.

Comments

@dudo50
Copy link
Contributor

dudo50 commented Feb 9, 2024

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Description of bug

We have just submitted on-chain referenda, but when we submitted the preimage it did not show on the Preimage screen in UI. What is strange, we can find it in the preimage pallet and it says it was unregistered - meaning our proposal will probably fail even if approved. Could anyone check on this, please? Also, the currency for the preimage is reserved, it did not return. We would love to believe, that this is just an error with UI and everything is fine.

Details:
Preimage: https://kusama.subscan.io/extrinsic/21799752-2
Preimage query: 0x758b3447bf2a8e9e61f3de3edf0a14e5f84fdd470eca5d1b991fbb02f6c03cd0
Screenshot 2024-02-09 at 10 06 08
Proposal: https://kusama.polkassembly.io/referenda/344
Network: Kusama

EDIT:

  • Other Kusama proposals reportedly also show unrequested.
  • Seen this on Polkadot proposals also, so it is probably not caused by the latest runtime update.
  • When I submitted same preimage it led to error, that it already exist, despite the fact, that it shown unrequested in the UI. So probably it is only issue with the UI. Would be cool if someone could confirm us on this. Thanks!

Steps to reproduce

Submit preimage.
Our preimage was
treasury.spendLocal

@dudo50 dudo50 added I10-unconfirmed Issue might be valid, but it's not yet known. I2-bug The node fails to follow expected behavior. labels Feb 9, 2024
@dudo50 dudo50 changed the title URGENT: New Runtime update - Preimage hash unnotes itself. New Runtime update - Preimage hash unnotes itself. Feb 9, 2024
@dudo50 dudo50 changed the title New Runtime update - Preimage hash unnotes itself. Queried Preimage Hash returns unrequested while it was not. Feb 9, 2024
@ggwpez
Copy link
Member

ggwpez commented Feb 9, 2024

We have just submitted on-chain referenda, but when we submitted the preimage it did not show on the Preimage screen in UI

The preimage page is buggy: #2869 and polkadot-js/apps#10141, nothing that we can do here.

What is strange, we can find it in the preimage pallet and it says it was unregistered

It says unrequested, not unregistered. The preimage was registered successfully and is there. You can query it with PreimageFor(0x758b3447bf2a8e9e61f3de3edf0a14e5f84fdd470eca5d1b991fbb02f6c03cd0, 43).

I think the governance referendum should then switch it to Requested, but maybe that does only happen after the preparation period is over.

@dudo50
Copy link
Contributor Author

dudo50 commented Feb 9, 2024

@ggwpez , not sure about switch to requested after preparation is done as other proposals that are already active still display unrequested.

Correct me if I am wrong.
Should the proposal be executed as expected if it passes and everything is set correctly then?

Thanks for the information.

@dudo50
Copy link
Contributor Author

dudo50 commented Feb 10, 2024

We have analyzed the code and found following:

	/// The associated preimage has not yet been requested by the system. The given deposit (if
	/// some) is being held until either it becomes requested or the user retracts the preimage.
	Unrequested { ticket: (AccountId, Ticket), len: u32 },
	/// There are a non-zero number of outstanding requests for this hash by this chain. If there
	/// is a preimage registered, then `len` is `Some` and it may be removed iff this counter
	/// becomes zero.
	Requested { maybe_ticket: Option<(AccountId, Ticket)>, count: u32, maybe_len: Option<u32> },

Closing this issue now, as all our concerns were explained in code.

@dudo50 dudo50 closed this as completed Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I2-bug The node fails to follow expected behavior. I10-unconfirmed Issue might be valid, but it's not yet known.
Projects
None yet
Development

No branches or pull requests

2 participants