Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore disable-runtime-api #1621

Closed
xlc opened this issue Sep 19, 2023 · 5 comments · May be fixed by polkadot-fellows/runtimes#292
Closed

restore disable-runtime-api #1621

xlc opened this issue Sep 19, 2023 · 5 comments · May be fixed by polkadot-fellows/runtimes#292
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D1-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase.

Comments

@xlc
Copy link
Contributor

xlc commented Sep 19, 2023

Removed at #1328 but we still need it

          A proper solution will be changes `disable-runtime-api` to `enable-runtime-api` and make it enabled by default so that new feature means add functionality, not the other way around.

Originally posted by @xlc in #1328 (comment)
@Polkadot-Forum
Copy link

This issue has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/wasm-view-functions/1045/7

@Ank4n
Copy link
Contributor

Ank4n commented Feb 29, 2024

cc: @NachoPal @bkchr

@ggwpez ggwpez added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D1-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. labels Mar 13, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Mar 26, 2024
@svyatonik
refactor transaction sign scheme (paritytech#1621)
21f0638
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Mar 27, 2024
@svyatonik
refactor transaction sign scheme (paritytech#1621)
380ba3a
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik
refactor transaction sign scheme (paritytech#1621)
b578650
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
refactor transaction sign scheme (paritytech#1621)
889833f
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
refactor transaction sign scheme (paritytech#1621)
2c3fb80
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
refactor transaction sign scheme (paritytech#1621)
aeedf79
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
refactor transaction sign scheme (paritytech#1621)
8025359
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
refactor transaction sign scheme (paritytech#1621)
dc48d01
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
refactor transaction sign scheme (paritytech#1621)
a9ef6c2
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
refactor transaction sign scheme (paritytech#1621)
23ce6b5
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
refactor transaction sign scheme (paritytech#1621)
b677672
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
refactor transaction sign scheme (paritytech#1621)
4a1c5c7
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
refactor transaction sign scheme (paritytech#1621)
277cd3b
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@svyatonik @serban300
refactor transaction sign scheme (paritytech#1621)
8a7d58a
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@svyatonik @serban300
refactor transaction sign scheme (paritytech#1621)
6c2838e
bkchr pushed a commit that referenced this issue Apr 10, 2024
@svyatonik @bkchr
refactor transaction sign scheme (#1621)
a979340
@bolajahmad
Copy link
Contributor

There's a commit here that removes the disable-runtime-api.
The solution should involve sort of a reversal of the changes here, am I right @xlc ?

@xlc
Copy link
Contributor Author

xlc commented Apr 24, 2024

yes

This was referenced Apr 29, 2024
Closed
Draft
@xlc
Copy link
Contributor Author

xlc commented Aug 15, 2024

not needed anymore

@xlc xlc closed this as completed Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D1-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

restored disable-runtime-api in runtime nodes bolajahmad/runtimes
5 participants
@xlc @Ank4n @ggwpez @bolajahmad @Polkadot-Forum