Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validator disabling in statement-distribution subsystem #1591

Closed
tdimitrov opened this issue Sep 15, 2023 · 1 comment · Fixed by #1841
Closed

Validator disabling in statement-distribution subsystem #1591

tdimitrov opened this issue Sep 15, 2023 · 1 comment · Fixed by #1841
Assignees
@ordian

Comments

@tdimitrov
Copy link
Contributor

Followup from #1259 (comment)

statement-distribution should be the main point where validator disabling is enforced. The subsystem should not accept, request, or distribute statements from disabled validators.

A modification to the statement-dist StatementStore would do most of the heavy-lifting here - three parts:

  1. StatementStore: generate request bitmasks which exclude disabled validators
  2. StatementStore reject statements related to disabled validators
  3. Manifest handling: do not count disabled validators towards the seconded & backing thresholds in the advertised bitmask. Likewise in request handling: skip disabled validators' statements in the response.

Part of #784
This was referenced Sep 15, 2023
Open
Merged
@ordian ordian self-assigned this Oct 8, 2023
@ordian ordian mentioned this issue Oct 10, 2023
Merged
5 tasks
@ordian ordian moved this to In Progress in parachains team board Oct 20, 2023
@ordian ordian moved this from In Progress to Review in progress in parachains team board Oct 30, 2023
@ordian ordian linked a pull request Nov 8, 2023 that will close this issue
statement-distribution: validator disabling #1841
Merged
5 tasks
ordian added a commit that referenced this issue Jan 10, 2024
@ordian @tdimitrov
statement-distribution: validator disabling (#1841)
a419532 
Closes #1591.

The purpose of this PR is filter out backing statements from the network
signed by disabled validators. This is just an optimization, since we
will do filtering in the runtime in #1863 to avoid nodes to filter
garbage out at block production time.

- [x] Ensure it's ok to fiddle with the mask of manifests
- [x] Write more unit tests
- [x] Test locally
- [x] simple zombienet test
- [x] PRDoc

---------

Co-authored-by: Tsvetomir Dimitrov <[email protected]>
@github-project-automation github-project-automation bot moved this from Review in progress to Completed in parachains team board Jan 10, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Mar 26, 2024
@svyatonik @bkontur
Use proper account types (paritytech#1591)
5c91941 
* use proper account types

* Update primitives/messages/src/source_chain.rs

Co-authored-by: Branislav Kontur <[email protected]>

Co-authored-by: Branislav Kontur <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Mar 27, 2024
@svyatonik @bkontur
Use proper account types (paritytech#1591)
13596d2 
* use proper account types

* Update primitives/messages/src/source_chain.rs

Co-authored-by: Branislav Kontur <[email protected]>

Co-authored-by: Branislav Kontur <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @bkontur
Use proper account types (paritytech#1591)
8872eac 
* use proper account types

* Update primitives/messages/src/source_chain.rs

Co-authored-by: Branislav Kontur <[email protected]>

Co-authored-by: Branislav Kontur <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @bkontur @serban300
Use proper account types (paritytech#1591)
99f6a8e 
* use proper account types

* Update primitives/messages/src/source_chain.rs

Co-authored-by: Branislav Kontur <[email protected]>

Co-authored-by: Branislav Kontur <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @bkontur @serban300
Use proper account types (paritytech#1591)
d86c0c8 
* use proper account types

* Update primitives/messages/src/source_chain.rs

Co-authored-by: Branislav Kontur <[email protected]>

Co-authored-by: Branislav Kontur <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @bkontur @serban300
Use proper account types (paritytech#1591)
697e2a1 
* use proper account types

* Update primitives/messages/src/source_chain.rs

Co-authored-by: Branislav Kontur <[email protected]>

Co-authored-by: Branislav Kontur <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @bkontur @serban300
Use proper account types (paritytech#1591)
3e923a8 
* use proper account types

* Update primitives/messages/src/source_chain.rs

Co-authored-by: Branislav Kontur <[email protected]>

Co-authored-by: Branislav Kontur <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @bkontur @serban300
Use proper account types (paritytech#1591)
0be42f7 
* use proper account types

* Update primitives/messages/src/source_chain.rs

Co-authored-by: Branislav Kontur <[email protected]>

Co-authored-by: Branislav Kontur <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @bkontur @serban300
Use proper account types (paritytech#1591)
46a7307 
* use proper account types

* Update primitives/messages/src/source_chain.rs

Co-authored-by: Branislav Kontur <[email protected]>

Co-authored-by: Branislav Kontur <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @bkontur @serban300
Use proper account types (paritytech#1591)
dd73229 
* use proper account types

* Update primitives/messages/src/source_chain.rs

Co-authored-by: Branislav Kontur <[email protected]>

Co-authored-by: Branislav Kontur <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @bkontur @serban300
Use proper account types (paritytech#1591)
4931163 
* use proper account types

* Update primitives/messages/src/source_chain.rs

Co-authored-by: Branislav Kontur <[email protected]>

Co-authored-by: Branislav Kontur <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @bkontur @serban300
Use proper account types (paritytech#1591)
a72829d 
* use proper account types

* Update primitives/messages/src/source_chain.rs

Co-authored-by: Branislav Kontur <[email protected]>

Co-authored-by: Branislav Kontur <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @bkontur @serban300
Use proper account types (paritytech#1591)
052a534 
* use proper account types

* Update primitives/messages/src/source_chain.rs

Co-authored-by: Branislav Kontur <[email protected]>

Co-authored-by: Branislav Kontur <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@svyatonik @bkontur @serban300
Use proper account types (paritytech#1591)
75586b5 
* use proper account types

* Update primitives/messages/src/source_chain.rs

Co-authored-by: Branislav Kontur <[email protected]>

Co-authored-by: Branislav Kontur <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@svyatonik @bkontur @serban300
Use proper account types (paritytech#1591)
a35ea5e 
* use proper account types

* Update primitives/messages/src/source_chain.rs

Co-authored-by: Branislav Kontur <[email protected]>

Co-authored-by: Branislav Kontur <[email protected]>
bkchr pushed a commit that referenced this issue Apr 10, 2024
@svyatonik @bkontur @bkchr
Use proper account types (#1591)
4f4200b 
* use proper account types

* Update primitives/messages/src/source_chain.rs

Co-authored-by: Branislav Kontur <[email protected]>

Co-authored-by: Branislav Kontur <[email protected]>
@Overkillus
Copy link
Contributor

Partially superseded by the new logic in preparation for re-enabling (we now use relay parent state instead of union of leaves). See: #4744

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ordian ordian

Labels
None yet
Projects
parachains team board
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

statement-distribution: validator disabling paritytech/polkadot-sdk
3 participants
@tdimitrov @ordian @Overkillus