Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RPC-Spec-V2] Storage: Add support for storage closest merkle descendant #14550 #1506

Closed
Tracked by #1516
lexnv opened this issue Sep 12, 2023 · 1 comment · Fixed by #1153
Closed
Tracked by #1516

[RPC-Spec-V2] Storage: Add support for storage closest merkle descendant #14550 #1506

lexnv opened this issue Sep 12, 2023 · 1 comment · Fixed by #1153
Labels
I5-enhancement An additional feature request.

Comments

@lexnv
Copy link
Contributor

lexnv commented Sep 12, 2023

Fetch the Merkel value of the provided key when using the closest-descendant-merkle-value param.
When the key is not present in the trie, the Merkle value of the closest descendant must be returned.

From spec: https://github.com/paritytech/json-rpc-interface-spec/blob/main/src/api/chainHead_unstable_storage.md

If the type of an item is closest-descendant-merkle-value, then the so-called trie Merkle value of the key can be found in the result. If key doesn't exist in the trie, then the Merkle value of the closest descendant of key (including branch nodes) is provided. If key doesn't have any descendant in the trie, then the result will not contain any relevant item.

@paritytech/subxt-team

From: paritytech/substrate#14550
@lexnv lexnv added the I5-enhancement An additional feature request. label Sep 12, 2023
@lexnv
Copy link
Contributor Author

lexnv commented Sep 12, 2023

Since this issue is the last remaining bit of work for back-porting the chainHead, the following are not migrated:

This was referenced Sep 12, 2023
Closed
Open
Merged
lexnv added a commit that referenced this issue Sep 18, 2023
@lexnv @skunert
chainHead: Add support for storage closest merkle descendant #14818 (#…
5d34664 
…1153)

This PR adds support for fetching the closest merkle value of some key.


Builds on top of
- paritytech/trie#199

Migrates paritytech/substrate#14818 to the
monorepo.
Closes: paritytech/substrate#14550
Closes: #1506

// @paritytech/subxt-team

---------

Signed-off-by: Alexandru Vasile <[email protected]>
Co-authored-by: Sebastian Kunert <[email protected]>
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this issue Mar 25, 2024
@lexnv @skunert
chainHead: Add support for storage closest merkle descendant #14818 (p…
a5a37f8 
…aritytech#1153)

This PR adds support for fetching the closest merkle value of some key.


Builds on top of
- paritytech/trie#199

Migrates paritytech/substrate#14818 to the
monorepo.
Closes: paritytech/substrate#14550
Closes: paritytech#1506

// @paritytech/subxt-team

---------

Signed-off-by: Alexandru Vasile <[email protected]>
Co-authored-by: Sebastian Kunert <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@nuke-web3 @serban300
rm substrate.dev homepage (paritytech#1506)
07daef0 
new docs page
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@nuke-web3 @serban300
rm substrate.dev homepage (paritytech#1506)
616125f 
new docs page
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@nuke-web3 @serban300
rm substrate.dev homepage (paritytech#1506)
4d293fe 
new docs page
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@nuke-web3 @serban300
rm substrate.dev homepage (paritytech#1506)
507eded 
new docs page
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@nuke-web3 @serban300
rm substrate.dev homepage (paritytech#1506)
ef2c861 
new docs page
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@nuke-web3 @serban300
rm substrate.dev homepage (paritytech#1506)
aa284d8 
new docs page
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@nuke-web3 @serban300
rm substrate.dev homepage (paritytech#1506)
edb694b 
new docs page
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@nuke-web3 @serban300
rm substrate.dev homepage (paritytech#1506)
877e5be 
new docs page
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@nuke-web3 @serban300
rm substrate.dev homepage (paritytech#1506)
41c7536 
new docs page
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@nuke-web3 @serban300
rm substrate.dev homepage (paritytech#1506)
482edc5 
new docs page
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@nuke-web3 @serban300
rm substrate.dev homepage (paritytech#1506)
3743776 
new docs page
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@nuke-web3 @serban300
rm substrate.dev homepage (paritytech#1506)
7990efc 
new docs page
bkchr pushed a commit that referenced this issue Apr 10, 2024
@nuke-web3 @bkchr
rm substrate.dev homepage (#1506)
e9d7adf 
new docs page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I5-enhancement An additional feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chainHead: Add support for storage closest merkle descendant #14818 paritytech/polkadot-sdk
1 participant
@lexnv