Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove All "Free for All" Collator Selection #103

Closed
joepetrowski opened this issue Jul 17, 2023 · 3 comments · Fixed by #1251
Closed

Remove All "Free for All" Collator Selection #103

joepetrowski opened this issue Jul 17, 2023 · 3 comments · Fixed by #1251
Assignees
@NachoPal @georgepisaltu
Labels
I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. T1-FRAME This PR/Issue is related to core FRAME, the framework.

Comments

@joepetrowski
Copy link
Contributor

As part of block builder improvements, all parachains should have a configurable collator set (e.g. using Aura). Off the top of my head, this means changing Gluttons, but there may be some others (Penpal, Contracts, Template) that need changing too.

From @rphmeier :

The "free for all" system does not work for building a backlog of blocks with more than a single collator.
@joepetrowski joepetrowski added I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. T1-runtime labels Jul 17, 2023
@bkchr
Copy link
Member

bkchr commented Jul 18, 2023

The "free for all" system does not work for building a backlog of blocks with more than a single collator.

This is right, but these chains should just disable to have unincluded blocks.

@rphmeier
Copy link
Contributor

rphmeier commented Jul 20, 2023 •
edited
Loading

Here's an example of how to continue using free-for-all consensus with some deprecated functions.

https://github.com/paritytech/cumulus/blob/4a5ec22a3b65629d988bdbeec68e083c67001526/polkadot-parachain/src/service.rs#L924-L974

FWIW we could implement a simple "free-for-all" collator using the new architecture. The only reason those functions are currently considered deprecated is because they imply that it's the correct way to start a collator (and need to be kept in for backcompat reasons).

So this issue could also be "write a new FreeForAll collator using new collator architecture". I do really dislike the name RelayChainConsensus as the relay-chain doesn't provide any sybil resistance.

@rphmeier
Copy link
Contributor

rphmeier commented Jul 26, 2023 •
edited
Loading

A couple bullet points for implementation notes:

@joepetrowski joepetrowski transferred this issue from paritytech/cumulus Aug 24, 2023
@the-right-joyce the-right-joyce added T1-FRAME This PR/Issue is related to core FRAME, the framework. and removed T1-runtime labels Aug 25, 2023
@georgepisaltu georgepisaltu mentioned this issue Aug 29, 2023
Merged
georgepisaltu added a commit that referenced this issue Sep 18, 2023
@georgepisaltu
Replace free for all collation in cumulus runtimes (#1251)
a181ced 
Partially fixes #103 

This PR removes instances of "free for all" collation in the `glutton`,
`shell`, and `seedling` runtimes and replaces them with Aura instances.
Aura is configured without a session manager, so the initial authority
set cannot be changed later on.

---------

Signed-off-by: georgepisaltu <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @HCastano @serban300
Use runtime storage in PoA -> Substrate module tests (paritytech#103)
1f5e507 
* removeInMemoryStorage + extract Kovan stuff to runtime

* removed comment from the future

* remove redundant conversions

* remove redundant `u8 as usize`

* remove redundant `u8 as usize`

* Update modules/ethereum/src/mock.rs

Co-authored-by: Hernando Castano <[email protected]>

* use hex-literal in kovan config

* cargo fmt --all

* extracted insert_header

* cargo fmt --all

Co-authored-by: Hernando Castano <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @HCastano @serban300
Use runtime storage in PoA -> Substrate module tests (paritytech#103)
bb2ef9f 
* removeInMemoryStorage + extract Kovan stuff to runtime

* removed comment from the future

* remove redundant conversions

* remove redundant `u8 as usize`

* remove redundant `u8 as usize`

* Update modules/ethereum/src/mock.rs

Co-authored-by: Hernando Castano <[email protected]>

* use hex-literal in kovan config

* cargo fmt --all

* extracted insert_header

* cargo fmt --all

Co-authored-by: Hernando Castano <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @HCastano @serban300
Use runtime storage in PoA -> Substrate module tests (paritytech#103)
8954167 
* removeInMemoryStorage + extract Kovan stuff to runtime

* removed comment from the future

* remove redundant conversions

* remove redundant `u8 as usize`

* remove redundant `u8 as usize`

* Update modules/ethereum/src/mock.rs

Co-authored-by: Hernando Castano <[email protected]>

* use hex-literal in kovan config

* cargo fmt --all

* extracted insert_header

* cargo fmt --all

Co-authored-by: Hernando Castano <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @HCastano @serban300
Use runtime storage in PoA -> Substrate module tests (paritytech#103)
c26383b 
* removeInMemoryStorage + extract Kovan stuff to runtime

* removed comment from the future

* remove redundant conversions

* remove redundant `u8 as usize`

* remove redundant `u8 as usize`

* Update modules/ethereum/src/mock.rs

Co-authored-by: Hernando Castano <[email protected]>

* use hex-literal in kovan config

* cargo fmt --all

* extracted insert_header

* cargo fmt --all

Co-authored-by: Hernando Castano <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @HCastano @serban300
Use runtime storage in PoA -> Substrate module tests (paritytech#103)
e489160 
* removeInMemoryStorage + extract Kovan stuff to runtime

* removed comment from the future

* remove redundant conversions

* remove redundant `u8 as usize`

* remove redundant `u8 as usize`

* Update modules/ethereum/src/mock.rs

Co-authored-by: Hernando Castano <[email protected]>

* use hex-literal in kovan config

* cargo fmt --all

* extracted insert_header

* cargo fmt --all

Co-authored-by: Hernando Castano <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @HCastano @serban300
Use runtime storage in PoA -> Substrate module tests (paritytech#103)
2703d36 
* removeInMemoryStorage + extract Kovan stuff to runtime

* removed comment from the future

* remove redundant conversions

* remove redundant `u8 as usize`

* remove redundant `u8 as usize`

* Update modules/ethereum/src/mock.rs

Co-authored-by: Hernando Castano <[email protected]>

* use hex-literal in kovan config

* cargo fmt --all

* extracted insert_header

* cargo fmt --all

Co-authored-by: Hernando Castano <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @HCastano @serban300
Use runtime storage in PoA -> Substrate module tests (paritytech#103)
9352bd5 
* removeInMemoryStorage + extract Kovan stuff to runtime

* removed comment from the future

* remove redundant conversions

* remove redundant `u8 as usize`

* remove redundant `u8 as usize`

* Update modules/ethereum/src/mock.rs

Co-authored-by: Hernando Castano <[email protected]>

* use hex-literal in kovan config

* cargo fmt --all

* extracted insert_header

* cargo fmt --all

Co-authored-by: Hernando Castano <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @HCastano @serban300
Use runtime storage in PoA -> Substrate module tests (paritytech#103)
ea4a58b 
* removeInMemoryStorage + extract Kovan stuff to runtime

* removed comment from the future

* remove redundant conversions

* remove redundant `u8 as usize`

* remove redundant `u8 as usize`

* Update modules/ethereum/src/mock.rs

Co-authored-by: Hernando Castano <[email protected]>

* use hex-literal in kovan config

* cargo fmt --all

* extracted insert_header

* cargo fmt --all

Co-authored-by: Hernando Castano <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@svyatonik @HCastano @serban300
Use runtime storage in PoA -> Substrate module tests (paritytech#103)
3ac1385 
* removeInMemoryStorage + extract Kovan stuff to runtime

* removed comment from the future

* remove redundant conversions

* remove redundant `u8 as usize`

* remove redundant `u8 as usize`

* Update modules/ethereum/src/mock.rs

Co-authored-by: Hernando Castano <[email protected]>

* use hex-literal in kovan config

* cargo fmt --all

* extracted insert_header

* cargo fmt --all

Co-authored-by: Hernando Castano <[email protected]>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@svyatonik @HCastano @serban300
Use runtime storage in PoA -> Substrate module tests (paritytech#103)
227129d 
* removeInMemoryStorage + extract Kovan stuff to runtime

* removed comment from the future

* remove redundant conversions

* remove redundant `u8 as usize`

* remove redundant `u8 as usize`

* Update modules/ethereum/src/mock.rs

Co-authored-by: Hernando Castano <[email protected]>

* use hex-literal in kovan config

* cargo fmt --all

* extracted insert_header

* cargo fmt --all

Co-authored-by: Hernando Castano <[email protected]>
jonathanudd pushed a commit to jonathanudd/polkadot-sdk that referenced this issue Apr 10, 2024
@svyatonik @HCastano @bkchr
Use runtime storage in PoA -> Substrate module tests (paritytech#103)
a6a86c2 
* removeInMemoryStorage + extract Kovan stuff to runtime

* removed comment from the future

* remove redundant conversions

* remove redundant `u8 as usize`

* remove redundant `u8 as usize`

* Update modules/ethereum/src/mock.rs

Co-authored-by: Hernando Castano <[email protected]>

* use hex-literal in kovan config

* cargo fmt --all

* extracted insert_header

* cargo fmt --all

Co-authored-by: Hernando Castano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NachoPal NachoPal

@georgepisaltu georgepisaltu

Labels
I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace free for all collation in cumulus runtimes paritytech/polkadot-sdk
6 participants
@bkchr @rphmeier @NachoPal @joepetrowski @georgepisaltu @the-right-joyce