Skip to content

Commit

Permalink
statement-distribution: validator disabling
Browse files Browse the repository at this point in the history
  • Loading branch information
ordian committed Dec 20, 2023
1 parent a954ca5 commit c3bb3f4
Show file tree
Hide file tree
Showing 15 changed files with 1,396 additions and 666 deletions.
8 changes: 8 additions & 0 deletions .gitlab/pipeline/zombienet/polkadot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,14 @@ zombienet-polkadot-functional-0008-dispute-old-finalized:
--local-dir="${LOCAL_DIR}/functional"
--test="0008-dispute-old-finalized.zndsl"

zombienet-polkadot-functional-0009-validator-disabling:
extends:
- .zombienet-polkadot-common
script:
- /home/nonroot/zombie-net/scripts/ci/run-test-local-env-manager.sh
--local-dir="${LOCAL_DIR}/functional"
--test="0009-validator-disabling.zndsl"

zombienet-polkadot-smoke-0001-parachains-smoke-test:
extends:
- .zombienet-polkadot-common
Expand Down
5 changes: 4 additions & 1 deletion polkadot/node/network/statement-distribution/src/error.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
use polkadot_node_network_protocol::PeerId;
use polkadot_node_subsystem::{RuntimeApiError, SubsystemError};
use polkadot_node_subsystem_util::{
backing_implicit_view::FetchError as ImplicitViewFetchError, runtime,
self as util, backing_implicit_view::FetchError as ImplicitViewFetchError, runtime,
};
use polkadot_primitives::{CandidateHash, Hash, Id as ParaId};

Expand Down Expand Up @@ -75,6 +75,9 @@ pub enum Error {
#[error("Fetching availability cores failed {0:?}")]
FetchAvailabilityCores(RuntimeApiError),

#[error("Fetching disabled validators failed {0:?}")]
FetchDisabledValidators(util::Error),

#[error("Fetching validator groups failed {0:?}")]
FetchValidatorGroups(RuntimeApiError),

Expand Down
4 changes: 3 additions & 1 deletion polkadot/node/network/statement-distribution/src/v2/grid.rs
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,9 @@ impl GridTracker {
/// This checks whether the peer is allowed to send us manifests
/// about this group at this relay-parent. This also does sanity
/// checks on the format of the manifest and the amount of votes
/// it contains. It has effects on the stored state only when successful.
/// it contains. It assumes that the votes from disabled validators
/// are already filtered out.
/// It has effects on the stored state only when successful.
///
/// This returns a `bool` on success, which if true indicates that an acknowledgement is
/// to be sent in response to the received manifest. This only occurs when the
Expand Down
Loading

0 comments on commit c3bb3f4

Please sign in to comment.