Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Parachain ID Parameter #151

Open
HCastano opened this issue Nov 11, 2021 · 3 comments
Open

Remove Parachain ID Parameter #151

HCastano opened this issue Nov 11, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@HCastano
Copy link

Due to paritytech/cumulus#739 polkadot-launch isn't able to launch collators properly since it makes use of the --parachain-id flag. We should update the tool accordingly.

@HCastano HCastano added the bug Something isn't working label Nov 11, 2021
@nuke-web3
Copy link

nuke-web3 commented Nov 11, 2021

bummer. I will make a note in the tutorial, and watch for this to be resolved to re introduce using this great tool.

might need some plain chainspecs and a bit of find and replace magic now to get raw specs to use here?

@brunopgalvao
Copy link
Contributor

brunopgalvao commented Mar 3, 2022

Currently the polkadot-launch config.json parachains id values are overridden by this line in cumulus:

1000.into(),

this makes it challenging to have polkadot-launch spin off multiple parachains with different ids.

Just to be clear, the parachain ids are being picked up off of the config file for the relay chain but not for the individual parachain nodes they are defaulting to 1000 because they are hardcoded in cumulus.

Screen Shot 2022-03-03 at 10 21 14 AM
Screen Shot 2022-03-03 at 10 22 12 AM

Any ideas on best course of action?

tagging: @Imod7 @al3mart

@al3mart
Copy link
Contributor

al3mart commented Mar 3, 2022

So, the id that you specify in the config file for polkadot-launch is the one that will be reserved in the relay chain and for which the state and wasm of the para will be registered, and only that.

The paraId on the state of the para will be defined by whatever exits on the chain_spec that para is running. What you have linked in your comment is the genesis config where you can see the value 1000 being set as the paraId in the state of the para.

On the topic of the issue itself, current master branch of polkadot-launch doesn't add --para-id flag when running the collators, so maybe it will be a good moment for a new (minor?)version of the tool.

(closed by misclick, reopening)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants