Skip to content
This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

merge queue fails when it reaches PR from fork, can't push lock updates there #399

Open
mordamax opened this issue Sep 27, 2022 · 0 comments
Labels
invalid This doesn't seem right

Comments

@mordamax
Copy link
Contributor

From Matrix

Oliver Tale-Yazdi.unwrap():
Maybe we can add a "permission check" as part of the companion MR, sometimes it dies when trying to merge a companion since the bot cannot push to the branch. Exampls https://github.com/paritytech/cumulus/pull/1613/#issuecomment-1257677400 

Mak
like - when you type bot merge from substrate, it will check if polkadot & cumulus MRs are pushable?

Oliver Tale-Yazdi.unwrap()
Maybe even when it realizes that you linked a companion. But yea; checking before merging upstream is the important part.

One of the solutions could be - when someone write "bot merge", there are list of checks that bot does, to make sure that all companions are mergeable - that could be a place to also check if companion PRs are pushable

@mordamax mordamax added bug Something isn't working invalid This doesn't seem right and removed bug Something isn't working labels Sep 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant