Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parity-util-mem #696

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Remove parity-util-mem #696

merged 2 commits into from
Nov 29, 2022

Conversation

mrcnski
Copy link
Contributor

@mrcnski mrcnski commented Nov 28, 2022

PULL REQUEST

Overview

Removes parity-util-mem from kvdb, kvdb-memorydb and kvdb-rocksdb.

Note that we will still need to update the versions, changelogs, and git tags for these crates, and then publish them. I can do that in this PR, if desired, or someone else can.

Related Issues

See paritytech/substrate#12658.

@mrcnski mrcnski requested a review from ordian November 28, 2022 14:44
@ordian ordian added the breaking-change Breaking change label Nov 28, 2022
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to update changelogs as well. I'd prefer to see substrate removing references to it first.

@mrcnski
Copy link
Contributor Author

mrcnski commented Nov 28, 2022

Would be nice to update changelogs as well. I'd prefer to see substrate removing references to it first.

I can update changelogs. What about versions in Cargo.toml?

The substrate PR:

paritytech/substrate#12795

@ordian
Copy link
Member

ordian commented Nov 29, 2022

Ok, I'll update versions and changelogs and take care of publishing.

Could you remove references to parity-util-mem in CI: https://github.com/paritytech/parity-common/blob/master/.github/workflows/ci.yml?

@mrcnski mrcnski requested a review from a team as a code owner November 29, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Breaking change changelog Needs to be added to the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants