uint: add casting from/to U64 #691
Conversation
|
After opening PR I realized the tests might not be sufficient, so I will add more. Will appreciate feedback if this is the right direction. |
| construct_uint! { | ||
| /// 64-bit unsigned integer. | ||
| #[cfg_attr(feature = "scale-info", derive(TypeInfo))] | ||
| pub struct U64(1); |
There was a problem hiding this comment.
I'm not keen on adding this type to primitives.
In fact, we wanted to remove it altogether, see #473 for the context.
There was a problem hiding this comment.
My bad for not reading this issue thoroughly, and thanks for pointing it out.
I understand now why you suggested adding this to ethereum-types a year ago in #473. Just for clarity, you are still okay with adding this functionality in general, right?
My motivation behind this is that there are still libraries that use U64 in certain cases (eg. ethers-rs block-num) and conversion to other uint types is currently not the most elegant as already pointed out in the referenced issue.
Add uint casting support for U64 in
primitive-typesfull_mulfor U64Fixes #568