keccak-hash: switch benches to criterion #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ordian
commented
Jan 14, 2020
•
ordian
commented
- keccak-hash: switch benches to criterion
- check benches on CI
- apply cargo fix
- updates docs to 2018 edition
NikVolf
reviewed
Jan 14, 2020
This reverts commit de30cd7.
NikVolf
approved these changes
Jan 14, 2020
dvdplm
approved these changes
Jan 14, 2020
| @@ -27,6 +27,7 @@ parity-util-mem = { path = "../parity-util-mem", version = "0.4", default-featur | |||
| [dev-dependencies] | |||
| alloc_counter = "0.0.4" | |||
| criterion = "0.3" | |||
| ethereum-types = { path = "../ethereum-types" } | |||
There was a problem hiding this comment.
I broke this in https://github.com/paritytech/parity-common/pull/301/files#diff-3206254ae7bfdf4d978075eb4cafbdcfR30, but we didn't have CI checks to catch it because keccak-hash benches didn't compile on stable I think?
There was a problem hiding this comment.
(this is a bench-only dependency)
Co-Authored-By: David <[email protected]>
ordian
added a commit
that referenced
this pull request
Jan 14, 2020
* master: keccak-hash: switch benches to criterion (#315)
dvdplm
added a commit
that referenced
this pull request
Feb 4, 2020
* master: update changelogs (#329) bump parity-util-mem to 0.4.2 (#328) remove libc feature from fixed-hash (#317) kvdb-rocksdb: release 0.4.2 (#327) kvdb-rocksdb: fix iter_from_prefix being slow (#326) MallocSizeOf for BTreeSet (#325) split off primitives (#323) travis: disable kvdb-web tests for chrome (#324) Expand const fn coverage (#319) uint: make zero const fn (#318) README: fix appveyor badge (#316) keccak-hash: switch benches to criterion (#315)
ordian
added a commit
that referenced
this pull request
Feb 6, 2020
* master: (56 commits) Remove libc completely (#333) update changelogs (#329) bump parity-util-mem to 0.4.2 (#328) remove libc feature from fixed-hash (#317) kvdb-rocksdb: release 0.4.2 (#327) kvdb-rocksdb: fix iter_from_prefix being slow (#326) MallocSizeOf for BTreeSet (#325) split off primitives (#323) travis: disable kvdb-web tests for chrome (#324) Expand const fn coverage (#319) uint: make zero const fn (#318) README: fix appveyor badge (#316) keccak-hash: switch benches to criterion (#315) update parity-util-mem (#309) Update features and feature dependencies (#307) Use proper memory queries to rocksdb (#308) Draft version updates and changelog (#299) Use custom error type for `from_hex` (#305) Fix typo. (#303) kvdb: remove KeyValueDBHandler (#304) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.