Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update features and feature dependencies #307

Merged
merged 6 commits into from
Jan 6, 2020
Merged

Update features and feature dependencies #307

merged 6 commits into from
Jan 6, 2020

Conversation

NikVolf
Copy link
Contributor

@NikVolf NikVolf commented Jan 4, 2020

No description provided.

ordian
ordian approved these changes Jan 4, 2020
View reviewed changes
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem like kvdb and kvdb-web require std feature of parity-util-mem, not sure if it matters though.

@NikVolf NikVolf changed the title Limit features of parity-util-mem dependency Update features and feature dependency Jan 4, 2020
@NikVolf
Copy link
Contributor Author

NikVolf commented Jan 4, 2020

I also moved SmallVec and fixed arrays implementations from ethereum feature (haven't realised they were there 🥺

@NikVolf NikVolf force-pushed the nv-dep-fix branch 2 times, most recently from 4cfd69a to a787090 Compare January 4, 2020 17:03
@ordian
Copy link
Member

ordian commented Jan 4, 2020 •
edited
Loading

I also moved SmallVec and fixed arrays implementations from ethereum feature (haven't realised they were there 🥺

Good catch! Might make sense to rename impl.rs to ethereum_impls.rs as well as move non-ethereum specific tests to other files accordingly.

@NikVolf NikVolf changed the title Update features and feature dependency Update features and feature dependencies Jan 4, 2020
dvdplm
dvdplm reviewed Jan 6, 2020
View reviewed changes
Copy link
Contributor

@dvdplm dvdplm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I think that the point of having the "impls.rs" module was to keep malloc_size.rs updateable from upstream with less hassle. Now that we're maintaining it ourselves, I don't think it makes sense to keep it at all. With the latest commits here we removed the last non-test code and renamed the file, but now the module level docs are wrong and the file only contains a few tests + macro invocations.
Can we move the smallvec tests, and perhaps just put the macro invocation behind a cfg anmd remove the impls.rs?

@NikVolf
Copy link
Contributor Author

NikVolf commented Jan 6, 2020

@dvdplm I moved smallvec tests and updated docs

having dedicated module for ethereum impls (now ethereum_impls) seems fine to me, even if it just has couple of macro invocations

@NikVolf NikVolf merged commit 102d3c8 into master Jan 6, 2020
@NikVolf NikVolf deleted the nv-dep-fix branch January 6, 2020 10:04
dvdplm added a commit that referenced this pull request Jan 14, 2020
@dvdplm
Merge branch 'master' into dp/chore/secp256k1-from-upstream
48a2ef6 
* master: (27 commits)
  update parity-util-mem (#309)
  Update features and feature dependencies (#307)
  Use proper memory queries to rocksdb (#308)
  Draft version updates and changelog (#299)
  Use custom error type for `from_hex` (#305)
  Fix typo. (#303)
  kvdb: remove KeyValueDBHandler (#304)
  extract common kvdb tests into a crate (#301)
  Expose to_hex and from_hex from impl-serde (#302)
  Add a top level function to parity-util-mem (#298)
  I/O statistic for key-value databases (#294)
  use for_tuples (#300)
  Add memory extensions for LRUCache, hashbrown (#293)
  Add memory stats for kvdb-s (#292)
  Provide #[derive(MallocSizeOf)] that is actually working (#291)
  Move and extend impls for locking primitives (#290)
  Update uint README (#288)
  Update README.md (#287)
  [ci]: remove feature flags in virtual workspace (#289)
  Prepare releases (#286)
  ...
ordian added a commit that referenced this pull request Feb 6, 2020
@ordian
Merge branch 'master' into ao-kvdb-sled
9ba45b7 
* master: (56 commits)
  Remove libc completely (#333)
  update changelogs (#329)
  bump parity-util-mem to 0.4.2 (#328)
  remove libc feature from fixed-hash (#317)
  kvdb-rocksdb: release 0.4.2 (#327)
  kvdb-rocksdb: fix iter_from_prefix being slow (#326)
  MallocSizeOf for BTreeSet (#325)
  split off primitives (#323)
  travis: disable kvdb-web tests for chrome (#324)
  Expand const fn coverage (#319)
  uint: make zero const fn (#318)
  README: fix appveyor badge (#316)
  keccak-hash: switch benches to criterion (#315)
  update parity-util-mem (#309)
  Update features and feature dependencies (#307)
  Use proper memory queries to rocksdb (#308)
  Draft version updates and changelog (#299)
  Use custom error type for `from_hex` (#305)
  Fix typo. (#303)
  kvdb: remove KeyValueDBHandler (#304)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvdplm dvdplm dvdplm approved these changes

@ordian ordian ordian approved these changes

Assignees
No one assigned
Labels
A8-looksgood
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NikVolf @ordian @dvdplm