Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvdb-rocksdb: consider removing the RwLock #314

Closed
ordian opened this issue Jan 14, 2020 · 1 comment
Closed

kvdb-rocksdb: consider removing the RwLock #314

ordian opened this issue Jan 14, 2020 · 1 comment
Labels
F6-refactor F7-optimisation P7-nicetohave

Comments

@ordian
Copy link
Member

ordian commented Jan 14, 2020 •
edited
Loading

Currently we use RwLock<Option<DBAndColumns>> in order to:

  • support closing/upgrading (see restore) a RocksDB kvdb database.
  • hold a read lock to prevent closing the db via restoration
  • add and remove column methods takes self by ref

Another alternative to consider is to use https://docs.rs/arc-swap/0.4.4/arc_swap/.
What are the cons/pros of each approach?

cc #313 (comment)
@ordian ordian mentioned this issue Jan 14, 2020
Merged
@ordian
Copy link
Member Author

ordian commented Feb 4, 2022

closing as wontfix since we're deprecating kvdb-rocksdb

@ordian ordian closed this as completed Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
F6-refactor F7-optimisation P7-nicetohave
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ordian