Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for MMR::on_initialize() vs Session::on_initialize() #2579

Open
bkontur opened this issue Sep 22, 2023 · 3 comments
Open

Add test for MMR::on_initialize() vs Session::on_initialize() #2579

bkontur opened this issue Sep 22, 2023 · 3 comments
Assignees
Labels
Good First Issue Good for newcomers

Comments

@bkontur
Copy link
Contributor

bkontur commented Sep 22, 2023

Based on element discussion.

@bkontur bkontur self-assigned this Sep 22, 2023
@acatangiu
Copy link
Collaborator

@bkontur I can't see the "element discussion" anymore - do you still have the details of this issue?

@serban300
Copy link
Collaborator

I think it was related to checking that MMR::on_initialize() is called before Session::on_initialize(). We weren't sure this would still be the case after construct runtime v2. But in the meanwhile I think we rolled-back the logic related to calling MMR::on_initialize() before Session::on_initialize() ? So maybe we can close this issue.

@acatangiu
Copy link
Collaborator

hmm, in that case we could still have the test, but checking the order:

  1. Session
  2. MMR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good for newcomers
Projects
Status: No status
Development

No branches or pull requests

3 participants