Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add E2E tests for Mapping functions #1492

Merged
merged 21 commits into from
Dec 21, 2022
Merged

Add E2E tests for Mapping functions #1492

merged 21 commits into from
Dec 21, 2022

Conversation

SkymanOne
Copy link
Contributor

This PR fixes #1488 and closes #1472 by adding E2E tests for all Mapping functions and correctly submitting the origin of the dry-run call during E2E test

@SkymanOne SkymanOne changed the title Add E2E tests for Mapping functions & fix E2E dry-run for Mappping::insert() Add E2E tests for Mapping functions Nov 11, 2022
HCastano
HCastano reviewed Nov 22, 2022
View reviewed changes
Copy link
Contributor

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing major. You're gonna need to do some fixes for the LangError changes

examples/mappings/Cargo.toml Outdated Show resolved Hide resolved
examples/mappings/Cargo.toml Outdated Show resolved Hide resolved
examples/mappings/lib.rs Outdated Show resolved Hide resolved
examples/mappings/lib.rs Outdated Show resolved Hide resolved
examples/mappings/lib.rs Outdated Show resolved Hide resolved
examples/mappings/lib.rs Outdated Show resolved Hide resolved
examples/mappings/lib.rs Outdated Show resolved Hide resolved
examples/mappings/lib.rs Outdated Show resolved Hide resolved
examples/mappings/lib.rs Outdated Show resolved Hide resolved
examples/mappings/lib.rs Outdated Show resolved Hide resolved
ascjones
ascjones reviewed Nov 30, 2022
View reviewed changes
examples/mappings/lib.rs Outdated Show resolved Hide resolved
ascjones
ascjones approved these changes Dec 2, 2022
View reviewed changes
Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would wait until substrate-contracts-node is updated and the tests actually pass until merging. Otherwise our master CI will be red.

examples/mapping_integration_tests/Cargo.toml Outdated Show resolved Hide resolved
examples/mapping_integration_tests/lib.rs Outdated Show resolved Hide resolved
@SkymanOne SkymanOne merged commit 4655a8b into master Dec 21, 2022
@SkymanOne SkymanOne deleted the gn/mapping-take-tests branch December 21, 2022 12:59
@agryaznov agryaznov mentioned this pull request Dec 22, 2022
Merged
HCastano pushed a commit that referenced this pull request Jan 23, 2023
@HCastano
Add E2E tests for Mapping functions (#1492)
dc9d5ac
@HCastano HCastano mentioned this pull request Jan 24, 2023
Merged
@ascjones ascjones mentioned this pull request Feb 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascjones ascjones ascjones approved these changes

@cmichi cmichi Awaiting requested review from cmichi cmichi is a code owner

@HCastano HCastano Awaiting requested review from HCastano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mapping::insert() fails in E2E tests Add E2E test for take_storage
3 participants
@SkymanOne @ascjones @HCastano