Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix Testing for Examples #14

Open
ryanleecode opened this issue Apr 28, 2023 · 2 comments
Open

Matrix Testing for Examples #14

ryanleecode opened this issue Apr 28, 2023 · 2 comments

Comments

@ryanleecode
Copy link
Collaborator

For virtual.eg.ts we currently test it as is without specifying the state flag. How might we approach testing no state flag and with state flag to get full coverage. Same question for other examples with flags.

This is important if we plan on adding additional flags i.e. use-stash and want full test coverage

const args = parse(Deno.args, { string: ["state"], boolean: ["use-stash"] })
@tjjfvi
Copy link
Contributor

tjjfvi commented Apr 28, 2023

Perhaps this would be best as an issue on https://github.com/paritytech/egts?

@harrysolovay
Copy link
Contributor

harrysolovay commented Apr 29, 2023

Agreed: we can specify variants / alternative inputs in the frontmatter/module-level docs.

/**
 * // ...
 * @alt flags --state <somestatevaluehere>
 */

In this case, we specify an alternative run with the flags following flags.

We may also want to prefix egts-specific frontmatter fields (including @skip_test).

/**
 * // ...
 * @egts:alt flags --state <somestatevaluehere>
 */

@harrysolovay harrysolovay transferred this issue from paritytech/capi Apr 29, 2023
@tjjfvi tjjfvi removed this from Capi Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants