-
Notifications
You must be signed in to change notification settings - Fork 379
Conversation
required: true | ||
binary_url: | ||
description: A url to a Linux binary for the node containing the runtime to test | ||
default: https://github.com/paritytech/cumulus/releases/download/statemine_v3/polkadot-collator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is hard-coded to v3, we might want to default to latest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just an example to show the pattern. In general, users will NOT use latest, they will want to point at a specific version so having the version show up makes it easier. Once we have v4 released, it will be obviouls how to change the default string. If I replace with latest, the user will not (easily) know whether to use 3
or v3
for instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but in general, it's not great to separate the pipelines making them run independently
I agree. For now, many of the steps are manual. The reaons is that instead of going right away for a big CI pipeline that will sill surely fail in many places, it is much simpler to start formalizing with independant pipelines that can be started manually, troubleshooted and re-started indepdently. Once everything works 100%, we can collapse all of those into one single pipeline if that still makes sense. |
This PR adds running a manual check for the extrinsic ordering.
A test run can be seen here: https://github.com/chevdor/cumulus/actions/runs/1287438927
What currently fails for some reason atm is not critical, the CI seems to fail killing the
polkadot-collator
(it works fine withpolkadot
).