Companion for substrate#11618 #1367
Conversation
| TransactionPayment: pallet_transaction_payment::{Pallet, Storage, Event<T>} = 11, | ||
| AssetTxPayment: pallet_asset_tx_payment::{Pallet} = 12, |
There was a problem hiding this comment.
One question, if someone paid a transaction fee with an asset, would this still emit an event? I.e., should we also add Event<T> to AssetTxPayment?
I know it could be a bit beyond the scope of strictly a pallet_transaction_payment event, but I think it would be confusing for users to see events for one type of fee and not for another. Would it make sense to expand paritytech/substrate#11618 to include an event for pallet_asset_tx_payment as well?
There was a problem hiding this comment.
yes, sure. Lets do a follow up PR
There was a problem hiding this comment.
good , I would like to continue the job.
|
Merge cancelled due to error. Error: Checks failed for b541d13 |
…-to-Pallet-Transaction-Payment
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Checks failed for ca26c9c |
shawntabrizi
added
B0-silent
|
bot merge |
|
Waiting for commit status. |
This reverts commit 51e148d.
This reverts commit 51e148d.
This reverts commit d2dc82b.
paritytech/substrate#11618