-
Notifications
You must be signed in to change notification settings - Fork 379
Ensure relay chain block number strictly increases #1280
Conversation
This is a safeguard for when async backing is enabled on the relay chain and multiple parachain blocks per relay chain block are legal. We will need to later change this to support then multiple parachain blocks per relay chain block.
This means we cannot easily swap the relaychain of a testnet parachain, which is a very useful feature to maintain a long term testnet. |
Stuff like the latest message head already prevent this (it may currently works for you because you don't have send any messages on your test chain). However, I can make this configurable from the beginning. |
The latest message head can be fixed by setting storages on relaychain with sudo. We tried this with last rococo reset. We can't just bump block number on relaychain (or can we?) |
No, but if I make it configurable, you can ignore this test on your test parachain. |
That works. Can we make it configurable? Should I make a new issue? |
I will push the changes to this pr before merging it. |
Thanks. The name looks fine to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm just need to fix the test
@@ -107,6 +107,7 @@ impl Config for Test { | |||
type ReservedDmpWeight = ReservedDmpWeight; | |||
type XcmpMessageHandler = SaveIntoThreadLocal; | |||
type ReservedXcmpWeight = ReservedXcmpWeight; | |||
type CheckAssociatedRelayNumber = AnyRelayNumber; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be RelayNumberStrictlyIncreases
for the test below to work?
Co-authored-by: André Silva <[email protected]>
Co-authored-by: André Silva <[email protected]>
This is a safeguard for when async backing is enabled on the relay chain and multiple parachain
blocks per relay chain block are legal. We will need to later change this to support then multiple
parachain blocks per relay chain block.