Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

dir restructure to support more CGP #1266

Merged
merged 23 commits into from
May 20, 2022
Merged

dir restructure to support more CGP #1266

merged 23 commits into from
May 20, 2022

Conversation

gilescope
Copy link
Contributor

@gilescope gilescope commented May 17, 2022 •
edited
Loading

Readying the ground for more CGP. Fixes #1240

@gilescope gilescope requested review from a team and chevdor as code owners May 17, 2022 11:35
@hbulgarini hbulgarini requested a review from joepetrowski May 17, 2022 12:04
@chevdor
Copy link
Contributor

chevdor commented May 18, 2022

The following PR should be merged to master before we merge that one: #1265

We will then need a rebase.

chevdor
chevdor suggested changes May 18, 2022
View reviewed changes
polkadot-parachain/Cargo.toml Outdated Show resolved Hide resolved
@hbulgarini hbulgarini mentioned this pull request May 18, 2022
Closed
@hbulgarini hbulgarini self-requested a review May 19, 2022 07:58
@chevdor chevdor force-pushed the giles-dir-restructure branch from 936ced0 to a328bf2 Compare May 19, 2022 12:54
joepetrowski
joepetrowski approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@joepetrowski joepetrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides some minor linking errors and the smart-contracts vs. contracts question it LGTM.

.github/ISSUE_TEMPLATE/release.md Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
hbulgarini
hbulgarini approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@hbulgarini hbulgarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After several back and forth, the changes looks good to me.

chevdor
chevdor approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paritytech-ci paritytech-ci requested a review from a team May 20, 2022 10:30
@joepetrowski joepetrowski mentioned this pull request May 20, 2022
Merged
@gilescope
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Error: Checks failed for b71a6b6

@gilescope
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Error: Checks failed for b71a6b6

@gilescope gilescope merged commit 9405a96 into master May 20, 2022
@gilescope gilescope deleted the giles-dir-restructure branch May 20, 2022 12:43
@github-actions github-actions bot mentioned this pull request Jun 22, 2022
Closed
@ghzlatarev ghzlatarev mentioned this pull request Jul 29, 2022
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nuke-web3 nuke-web3 nuke-web3 left review comments

@niklasad1 niklasad1 niklasad1 left review comments

@cmichi cmichi cmichi left review comments

@sergejparity sergejparity sergejparity approved these changes

@joepetrowski joepetrowski joepetrowski approved these changes

@hbulgarini hbulgarini hbulgarini approved these changes

@rcny rcny rcny approved these changes

@chevdor chevdor chevdor approved these changes

@alvicsam alvicsam Awaiting requested review from alvicsam

@TriplEight TriplEight Awaiting requested review from TriplEight

@radupopa2010 radupopa2010 Awaiting requested review from radupopa2010

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

polkadot-parachains folder restructuring.
9 participants
@gilescope @chevdor @cmichi @rcny @hbulgarini @niklasad1 @joepetrowski @nuke-web3 @sergejparity