Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Log XCMP Queue Errors? #800

Closed
apopiak opened this issue Nov 26, 2021 · 5 comments
Closed

Log XCMP Queue Errors? #800

apopiak opened this issue Nov 26, 2021 · 5 comments
Labels
T6-XCM This PR/Issue is related to XCM.

Comments

@apopiak
Copy link
Contributor

apopiak commented Nov 26, 2021

The XCMP queue implementation currently just ignores messages that error with anything that's not WeightLimitReached.

Err(_) => {
// Message looks invalid; don't attempt to retry
},

We should probably log the errors so we can know when it happens?

@apopiak apopiak added T6-XCM This PR/Issue is related to XCM. Q2-easy labels Nov 26, 2021
@Doordashcon
Copy link
Contributor

Hi @apopiak been going through the code

what is a valid incoming XCMP message data?

@apopiak
Copy link
Contributor Author

apopiak commented Mar 18, 2022

what is a valid incoming XCMP message data?

you mean as a test case?

@Doordashcon
Copy link
Contributor

Yes pls

@apopiak
Copy link
Contributor Author

apopiak commented Apr 3, 2022

I would recommend just constructing one in some test code and printing it?
From XCMP perspective an empty XCM should probably be valid? So sth like Xcm(vec![]).encode()?

@bkchr
Copy link
Member

bkchr commented Apr 12, 2022

Done by #1147

@bkchr bkchr closed this as completed Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Development

No branches or pull requests

3 participants