fix: resolve tx calls based on current runtime #375

marshacb · 2024-02-29T14:51:31Z

Description

This PR refactors existing call selection logic into the resolveCall method on the AssetTransferAPI which determines the correct call type and call based on information obtained from the current runtime.

Changes

Refactored call selection logic into the resolveCall method
Added resolveCall unit tests for ParaTo,* SystemTo* and RelayTo* XCM directions
Fixed parachain primary asset tx construction to allow for xTokens transfers of parachain native assets (e.g. SDN -> Moonriver, MOVR -> Bifrost, etc.) which were previously constructed using only polkadotXcm.
Added RuntimeCallNotFound error variant
Updated parachain integration tests

closes: #368

add test cases for transferAssets call

…ive-runtime

added RuntimeCallNotFound BaseErrorEnum updated paraToParaTransferMultiAssets example

src/createXcmTypes/ParaToPara.ts

src/createXcmTypes/ParaToSystem.ts

src/errors/BaseError.ts

src/types.ts

TarikGul

Overall, amazing job. Just some small nits but its clearly much cleaner and a nice touch for future work 🚀

Imod7

There are some errors when I run yarn lint but they were not introduced from this PR. Just in case you would like to fix them.

Imod7

Great work! 💯 It is much more clean & clear with the resolveCall method 👏

src/AssetTransferApi.ts

src/createXcmCalls/util/establishXcmPallet.ts

TarikGul · 2024-03-01T12:09:07Z

There are some errors when I run yarn lint but they were not introduced from this PR. Just in case you would like to fix them.

It's probably something specific to your local machine since the CI is passing.

remove unneeded undefined assignment removed named tuple syntax for map types

marshacb added 9 commits February 16, 2024 08:37

add Westend metadata v1007000

ca6e72a

add test cases for transferAssets call

Merge branch 'main' into cameron-resolve-supported-calls-based-on-act…

cd53417

…ive-runtime

add system and para direction unit tests for resolveCall

1083c0c

add resolve call unit tests for system and relay directions

1d45b36

update docs

9434406

remove dev logs

e4d064e

revert fee asset item change

ec43eff

add util to check if call exists in runtime

1a44c01

added RuntimeCallNotFound BaseErrorEnum updated paraToParaTransferMultiAssets example

update docs

515f045

marshacb marked this pull request as ready for review February 29, 2024 16:57

marshacb requested review from Imod7, TarikGul and bee344 February 29, 2024 16:58

marshacb added 2 commits February 29, 2024 12:10

remove commented args

f269fce

lint

63d324d

marshacb changed the title ~~fix: resolve supported calls based on current runtime~~ fix: resolve tx calls based on current runtime Feb 29, 2024

revert local example changes

fdabd30