Skip to content
This repository has been archived by the owner on Feb 26, 2020. It is now read-only.

Clean codebase #92

Closed
amaury1093 opened this issue May 7, 2018 · 4 comments
Closed

Clean codebase #92

amaury1093 opened this issue May 7, 2018 · 4 comments
Assignees
Labels
P5-sometimesoon Issue is worth doing soon.

Comments

@amaury1093
Copy link
Contributor

Some ideas for removing deprecated stuff in the codebase:

@amaury1093 amaury1093 added the P5-sometimesoon Issue is worth doing soon. label May 7, 2018
@axelchalon
Copy link
Contributor

axelchalon commented May 17, 2018

Misc dapps stuff

In an effort to move all things dapps into the shell and away from Parity:

Dapps should be completely handled by the shell; Parity should play no role.

@amaury1093
Copy link
Contributor Author

Excellent summary.

cc @jacogr

@axelchalon
Copy link
Contributor

axelchalon commented Jul 12, 2018

Some documentation in the wiki about the way dapps work now would be nice. (no need to inclure inject.js anymore ; local dapps location ; dapp development experience with localUrl)

@amaury1093
Copy link
Contributor Author

I unchecked Once done, remove browser-specific code from shell.

There are a couple of isElectron() that could be removed. Also, iframes can be removed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P5-sometimesoon Issue is worth doing soon.
Projects
None yet
Development

No branches or pull requests

2 participants