bugfix and set default sql parser #552
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In doc db tables is create and migrate by execute the sql scripts in assets directory. In fact the db table is create by the utilize the info of annotated model class. SQLiteOpenHelper will set db version after execute the onCreate, this will case the onCreate got the wrong db version, and some migration sql script will never be executed. Signed-off-by: Peng Sun <[email protected]>
this parser will support multi-line sql. Signed-off-by: Peng Sun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In doc it says db tables is create and migrate by execute the
sql scripts in assets directory.
In fact in code the db table is create by the utilize the info of
annotated model class.
SQLiteOpenHelper will set db version after
execute the onCreate, this will case the onCreate got the wrong db
version, and some migration sql script will never be executed.
I correct this by the first commit.
The second commit will set the default sql parser to "delimited". This will support multi-line sql script.