Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add second image build step for kubernetes workflow #29

Merged
merged 18 commits into from
Dec 5, 2024

Conversation

kpplis
Copy link
Contributor

@kpplis kpplis commented Dec 2, 2024

  • Specifying target names causes corresponding amount of image builds in parallel

  • Target name is used for both specifying target in Containerfile and appending it to the image name at the end

  • All images have the same commit_sha tag

  • Commit and push new tag steps (and all consecutive ones) are moved to a separate job

  • Tested on flask-blueprint-app https://github.com/parcelLab/flask-blueprint-app/pull/23

@github-actions github-actions bot added the ci label Dec 2, 2024
@kpplis kpplis marked this pull request as ready for review December 2, 2024 12:47
@kpplis kpplis requested a review from a team as a code owner December 2, 2024 12:47
@kpplis kpplis merged commit e7fcb47 into main Dec 5, 2024
6 checks passed
@kpplis kpplis deleted the feat/kubernetes-build-second-image branch December 5, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants