Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position of all property is not maintained #746

Closed
JimDabell opened this issue May 24, 2024 · 3 comments
Closed

Position of all property is not maintained #746

JimDabell opened this issue May 24, 2024 · 3 comments

Comments

@JimDabell
Copy link

I have the following CSS:

button {
  all: unset;
  box-sizing: border-box;
  display: flex;
  align-items: center;
  gap: 0.375em;
  margin: 0;
  padding: 0.125em 0.5em;
  background: var(--post-background-lighter);
  border: thin solid var(--post-background-darker);
  border-radius: 1em;
  cursor: pointer;
}

When rendered with v1.24.1, the position of the all property is maintained:

button[data-v-77fddb74] {
  all: unset;
  box-sizing: border-box;
  background: var(--post-background-lighter);
  border: thin solid var(--post-background-darker);
  cursor: pointer;
  border-radius: 1em;
  align-items: center;
  gap: .375em;
  margin: 0;
  padding: .125em .5em;
  display: flex;
}

When rendered with v1.25.0, the position of the all property changes, breaking styles:

button[data-v-77fddb74] {
  box-sizing: border-box;
  background: var(--post-background-lighter);
  border: thin solid var(--post-background-darker);
  cursor: pointer;
  all: unset;
  border-radius: 1em;
  align-items: center;
  gap: .375em;
  margin: 0;
  padding: .125em .5em;
  display: flex;
}

I see a relevant commit d7aeff3 optimize "all" property, that has a comment:

// Always place the all property first. Previous properties will have been omitted.

This doesn’t appear to be correct.

@devongovett
Copy link
Member

Yeah this is a bad bug, sorry about that. I missed part of this. Will push a patch out asap

@devongovett
Copy link
Member

Fixed in v1.25.1. My apologies for the bug!

@JimDabell
Copy link
Author

I can confirm that’s fixed for me in v1.25.1. Thanks for the quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants