Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI incrorrectly trims Build ID #4649

Closed
brancz opened this issue May 20, 2024 · 0 comments · Fixed by #4653
Closed

UI incrorrectly trims Build ID #4649

brancz opened this issue May 20, 2024 · 0 comments · Fixed by #4653
Labels
bug Something isn't working

Comments

@brancz
Copy link
Member

brancz commented May 20, 2024 •
edited
Loading

Go Build IDs can contain /. It appears that we're incorrectly trimming BuildIDs at the last slash. Here's an example:

Screenshot 2024-05-20 at 15 42 20

While the full build ID is actually: Fs5xYOZ3wpIouy92ojuy/UzkJjxHgslNCusv_1E2o/QmGgGR1_3qINrqlVUt_Z/R0qBn2M0PS9pkPNAwzYs

When copying it's actually correct, it's just the tooltip that needs a fix.
@brancz brancz added the bug Something isn't working label May 20, 2024
@manojVivek manojVivek mentioned this issue May 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: Fixed the build id truncation on tooltip parca-dev/parca
1 participant
@brancz