Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve fgprof profiles in profile types dropdown #3199

Closed
metalmatze opened this issue May 30, 2023 · 1 comment · Fixed by #3210
Closed

Improve fgprof profiles in profile types dropdown #3199

metalmatze opened this issue May 30, 2023 · 1 comment · Fixed by #3210
Assignees
@themohammadsa
Labels
area/ui Something about the UI bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed tech-debt

Comments

@metalmatze
Copy link
Member

Although it seems we have fixed this issue in the past it must have slightly changed since and we are now seeing these types in the profile types dropdown:

Screenshot from 2023-05-30 16-09-47

It seems the types from the PR 568 are missing in the current ProfileSelector.tsx file on the main branch.
@metalmatze metalmatze added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers area/ui Something about the UI tech-debt labels May 30, 2023
@themohammadsa
Copy link
Contributor

hey @metalmatze!
I would like to pick this up. Could you assign it to me?

@themohammadsa themohammadsa mentioned this issue Jun 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@themohammadsa themohammadsa

Labels
area/ui Something about the UI bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bug fix: corrected the key for profile-selector themohammadsa/parca
2 participants
@metalmatze @themohammadsa