-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checks: Add "multiplexer" so that multiple web views can configure check service #1232
Comments
I propose the following:
And one of the following:
In either case, we will probably need to tune some things up like closing web views so they actually run the unsubscribers. I don't expect they do now. EDIT: I was linking to issue #1 on accident, but I meant to refer to item 1. Fixed |
Is it too early to consider using YJS docs for these settings? You can observe that doc for changes. And it would be moving in the right direction so that collab just works. |
This is primarily about configuring the check service, not storing settings. Setting storage will play a part in where things get persisted, but for the most part we're trying to decide how to take (currently) anonymous data subscribers for check results and make it so each can independently turn on/off checks on a per project and scripture range basis. I chatted with TJ in Discord, and the central idea suggested (as I understand it, though it isn't explicitly called out here) is making the anonymous subscribers no longer be anonymous. Every subscriber will have an ID. I think having an ID here probably makes sense, and the existing check service can manage subscriptions based on those IDs. Having said all this, I'm not sure I agree with dropping all the other endpoints. Instead it seems to me that the selectors (which are basically ignored now) can start to be used and be based on the subscription IDs. |
I think we can fix #1171 as part of this issue because we're going to have to be reworking the relevant part of the code anyway. |
May also be able to fix #1244 as part of this issue |
Test Repo steps:
|
#1222 implies multiple UIs will be configuring the check service, so we need a way for them all to communicate without overwriting settings from each other.
The text was updated successfully, but these errors were encountered: