Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error detection broken in parsec-cli-tests.sh #66

Closed
petedyer11 opened this issue Nov 25, 2021 · 0 comments · Fixed by #67
Closed

Error detection broken in parsec-cli-tests.sh #66

petedyer11 opened this issue Nov 25, 2021 · 0 comments · Fixed by #67
Assignees

Comments

@petedyer11
Copy link

The parsec-cli-tests script runs tests in a loop with a pipe command in it, which forces them to be run in a sub-shell.
The tests update EXIT_CODE correctly within the loop but that does not gets exported outside of the loop.
So any failures detected are not reported via the exit status of the script.

I provoked an error by changing "--key-name" to "--ky-name" in one of the checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants