Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review the default options #30

Closed
hug-dev opened this issue Feb 4, 2021 · 0 comments · Fixed by #32
Closed

Review the default options #30

hug-dev opened this issue Feb 4, 2021 · 0 comments · Fixed by #32
Assignees
@hug-dev
Labels
bug Something isn't working small Effort label

Comments

@hug-dev
Copy link
Member

hug-dev commented Feb 4, 2021

Currently a lot of defaults are handled with structopt default_value option but it might not be the best choice everywhere.

For example the provider field of ProviderOpts has that defaulted to zero where it should maybe be an Option and the None case can then be checked statically.

I spotted the following bug because of that:

[hugdev01@machine parsec-tool]$ ./target/debug/parsec-tool list-opcodes
[INFO] Available opcodes for provider MbedCrypto:
* ListProviders
* ListAuthenticators
* ListOpcodes
* ListKeys
* Ping

This is the case for ProviderOpts but let's review all of them.
@hug-dev hug-dev added bug Something isn't working small Effort label labels Feb 4, 2021
@hug-dev hug-dev self-assigned this Feb 4, 2021
@hug-dev hug-dev mentioned this issue Feb 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hug-dev hug-dev

Labels
bug Something isn't working small Effort label
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace default_value with Option hug-dev/parsec-tool
1 participant
@hug-dev