From c1490ffb2c62585b821063c420edc10d82da57e9 Mon Sep 17 00:00:00 2001 From: Matthias Seitz Date: Thu, 30 Nov 2023 12:06:51 +0100 Subject: [PATCH 1/4] ci: run clippy on all targets --- .github/workflows/lint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 60341fcb805b..3cd0d433599c 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -28,7 +28,7 @@ jobs: with: cache-on-failure: true - run: - cargo clippy --bin "${{ matrix.binary }}" --workspace --features "${{ matrix.network }}" + cargo clippy --bin "${{ matrix.binary }}" --workspace --features "${{ matrix.network }}" --all-targets env: RUSTFLAGS: -D warnings From 04f8da6fdb5eb5511b691c96b8850c02a6f4c7a6 Mon Sep 17 00:00:00 2001 From: Matthias Seitz Date: Thu, 30 Nov 2023 12:12:33 +0100 Subject: [PATCH 2/4] chore clippy --- examples/db-access.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/examples/db-access.rs b/examples/db-access.rs index dd9c74e58016..7fd888bb783e 100644 --- a/examples/db-access.rs +++ b/examples/db-access.rs @@ -1,12 +1,11 @@ use reth_db::open_db_read_only; -use reth_primitives::{Address, ChainSpecBuilder, B256, U256}; +use reth_primitives::{Address, ChainSpecBuilder, B256}; use reth_provider::{ AccountReader, BlockReader, BlockSource, HeaderProvider, ProviderFactory, ReceiptProvider, StateProvider, TransactionsProvider, }; use reth_rpc_types::{Filter, FilteredParams}; use reth_rpc_types_compat::log::from_primitive_log; - use std::path::Path; // Providers are zero cost abstractions on top of an opened MDBX Transaction From 35a5602ec7335651be2eea0db466b3c728989f24 Mon Sep 17 00:00:00 2001 From: Matthias Seitz Date: Thu, 30 Nov 2023 12:27:40 +0100 Subject: [PATCH 3/4] ci: run other targets --- .github/workflows/lint.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 3cd0d433599c..8d12948e5008 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -28,7 +28,7 @@ jobs: with: cache-on-failure: true - run: - cargo clippy --bin "${{ matrix.binary }}" --workspace --features "${{ matrix.network }}" --all-targets + cargo clippy --bin "${{ matrix.binary }}" --workspace --features "${{ matrix.network }}" --all-targets --lib env: RUSTFLAGS: -D warnings @@ -51,7 +51,7 @@ jobs: - uses: Swatinem/rust-cache@v2 with: cache-on-failure: true - - run: cargo build --bin "${{ matrix.binary }}" --workspace --features "${{ matrix.network }}" + - run: cargo build --bin "${{ matrix.binary }}" --workspace --features "${{ matrix.network }}" --lib --tests --benches --examples env: RUSTFLAGS: -D warnings From 60181861b777d0fb8510e23f96a3463c1f10c6f6 Mon Sep 17 00:00:00 2001 From: Matthias Seitz Date: Thu, 30 Nov 2023 12:27:52 +0100 Subject: [PATCH 4/4] ci: run other targets --- .github/workflows/lint.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 8d12948e5008..293831dcc2d5 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -28,7 +28,7 @@ jobs: with: cache-on-failure: true - run: - cargo clippy --bin "${{ matrix.binary }}" --workspace --features "${{ matrix.network }}" --all-targets --lib + cargo clippy --bin "${{ matrix.binary }}" --workspace --features "${{ matrix.network }}" --lib --tests --benches --examples env: RUSTFLAGS: -D warnings @@ -51,7 +51,7 @@ jobs: - uses: Swatinem/rust-cache@v2 with: cache-on-failure: true - - run: cargo build --bin "${{ matrix.binary }}" --workspace --features "${{ matrix.network }}" --lib --tests --benches --examples + - run: cargo build --bin "${{ matrix.binary }}" --workspace --features "${{ matrix.network }}" env: RUSTFLAGS: -D warnings