Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky downloaders test #8670

Closed
shekhirin opened this issue Jun 7, 2024 · 0 comments · Fixed by #8673
Closed

Flaky downloaders test #8670

shekhirin opened this issue Jun 7, 2024 · 0 comments · Fixed by #8673
Assignees
@emhane
Labels
A-downloaders Related to headers/bodies downloaders C-bug An unexpected or incorrect behavior C-test A change that impacts how or what we test

Comments

@shekhirin
Copy link
Collaborator

shekhirin commented Jun 7, 2024 •
edited by mattsse
Loading

Describe the bug

https://github.com/paradigmxyz/reth/actions/runs/9416510535/job/25939778770?pr=8658

test_chunk_download_headers_from_file sometimes fails with

---- file_client::tests::test_chunk_download_headers_from_file stdout ----
thread 'file_client::tests::test_chunk_download_headers_from_file' panicked at crates/net/downloaders/src/file_client.rs:621:51:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

and sometimes with

---- file_client::tests::test_chunk_download_headers_from_file stdout ----
thread 'file_client::tests::test_chunk_download_headers_from_file' panicked at crates/net/downloaders/src/file_client.rs:642:9:
assertion `left == right` failed

Steps to reproduce

hyperfine -r 100 --show-output "cargo test -p reth-downloaders test_chunk_download_headers_from_file"
@shekhirin shekhirin added C-bug An unexpected or incorrect behavior C-test A change that impacts how or what we test A-downloaders Related to headers/bodies downloaders labels Jun 7, 2024
@shekhirin shekhirin changed the title Flaky test_chunk_download_headers_from_file downloaders test Flaky downloaders test Jun 7, 2024
@mattsse mattsse mentioned this issue Jun 7, 2024
Merged
@mattsse mattsse closed this as completed Jun 7, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emhane emhane

Labels
A-downloaders Related to headers/bodies downloaders C-bug An unexpected or incorrect behavior C-test A change that impacts how or what we test
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix flaky test paradigmxyz/reth
3 participants
@shekhirin @mattsse @emhane