Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a --bootnodes flag for reth node #858

Closed
Tracked by #851
onbjerg opened this issue Jan 13, 2023 · 2 comments · Fixed by #867
Closed
Tracked by #851

Add a --bootnodes flag for reth node #858

onbjerg opened this issue Jan 13, 2023 · 2 comments · Fixed by #867
Assignees
Labels
A-cli Related to the reth CLI C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@onbjerg
Copy link
Collaborator

onbjerg commented Jan 13, 2023

Describe the feature

Currently we always use mainnet bootnodes, but they should be resolved loading the bootnodes chainspec (should be handled in #485). We should also provide the ability to override the bootnodes by specifying a --bootnodes flag.

The format should be --bootnodes <enrs> where <enrs> is a comma-seperated list of Ethereum node records.

The type should be Option<Vec<NodeRecord>>.

Additional context

To parse comma-separated values, clap provides value_delimiter. Example:

struct Opts {
  #[arg(long, value_delimiter = ',')]
  nodes: Option<Vec<NodeRecord>>
}
@onbjerg onbjerg added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started A-cli Related to the reth CLI labels Jan 13, 2023
@literallymarvellous
Copy link
Contributor

I'd like to take this.

@onbjerg onbjerg moved this from Todo to In Progress in Reth Tracker Jan 13, 2023
@onbjerg
Copy link
Collaborator Author

onbjerg commented Jan 13, 2023

Thanks! I've assigned you to the issue. If you feel stuck, open up a draft PR with your questions and someone will help you. If you are prevented from solving the issue, let me know and I will unassign you 😄

@onbjerg onbjerg linked a pull request Jan 13, 2023 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants