Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move reth-network config types to new crate network-types #8418

Closed
mattsse opened this issue May 27, 2024 · 4 comments · Fixed by #9136
Closed

Move reth-network config types to new crate network-types #8418

mattsse opened this issue May 27, 2024 · 4 comments · Fixed by #9136
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented May 27, 2024

Describe the feature

currently reth-config depends on a few types from network which are serializable:

use reth_network::{PeersConfig, SessionsConfig};

these can be also be moved to a new crate to keep network-api and network leaner and then re-export again from reth-network

/// Config type for initiating a [`PeersManager`] instance.
#[derive(Debug, Clone, PartialEq, Eq)]
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
#[cfg_attr(feature = "serde", serde(default))]
pub struct PeersConfig {

TODO

  • move relevant config types from reth-network to a new crate reth-network-types/src/config.rs

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels May 27, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started and removed S-needs-triage This issue needs to be labelled labels May 27, 2024
@polebug
Copy link

polebug commented May 28, 2024

Could I take this issue?

@wlawt
Copy link
Contributor

wlawt commented Jun 4, 2024

@polebug just wondering if you're still on this issue, or if you don't mind if i take an attempt

@polebug
Copy link

polebug commented Jun 5, 2024

@polebug just wondering if you're still on this issue, or if you don't mind if i take an attempt

I am still doing this.

@mattsse
Copy link
Collaborator Author

mattsse commented Jun 17, 2024

just checking in @polebug
do you have bandwidth to work on this?

@mattsse mattsse changed the title Move reth-network config types to network-api Move reth-network config types to new crate network-types Jun 25, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants