-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move reth-network config types to new crate network-types #8418
Labels
C-enhancement
New feature or request
D-good-first-issue
Nice and easy! A great choice to get started
Comments
mattsse
added
C-enhancement
New feature or request
S-needs-triage
This issue needs to be labelled
labels
May 27, 2024
mattsse
added
D-good-first-issue
Nice and easy! A great choice to get started
and removed
S-needs-triage
This issue needs to be labelled
labels
May 27, 2024
Could I take this issue? |
@polebug just wondering if you're still on this issue, or if you don't mind if i take an attempt |
I am still doing this. |
just checking in @polebug |
mattsse
changed the title
Move reth-network config types to network-api
Move reth-network config types to new crate network-types
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-enhancement
New feature or request
D-good-first-issue
Nice and easy! A great choice to get started
Describe the feature
currently reth-config depends on a few types from network which are serializable:
reth/crates/config/src/config.rs
Line 3 in e543983
these can be also be moved to a new crate to keep network-api and network leaner and then re-export again from reth-network
reth/crates/net/network/src/peers/manager.rs
Lines 1271 to 1275 in e543983
TODO
Additional context
No response
The text was updated successfully, but these errors were encountered: