Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support full payload validations for sidechains #5889

Closed
mattsse opened this issue Dec 29, 2023 · 1 comment · Fixed by #6131
Closed

Support full payload validations for sidechains #5889

mattsse opened this issue Dec 29, 2023 · 1 comment · Fixed by #6131
Assignees
Labels
C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Dec 29, 2023

Describe the feature

Due to past limitations, the state root check was skipped for blocks in sidechains:

/// Check if the block is known to blockchain tree or database and return its status.
///
/// Function will check:
/// * if block is inside database returns [BlockStatus::Valid].
/// * if block is inside buffer returns [BlockStatus::Disconnected].
/// * if block is part of a side chain returns [BlockStatus::Accepted].
/// * if block is part of the canonical returns [BlockStatus::Valid].
///
/// Returns an error if
/// - an error occurred while reading from the database.
/// - the block is already finalized
pub(crate) fn is_block_known(

This can cause attestation issues on 1-block reorgs/late blocks specifically with CL clients (lighthouse for example), because ACCEPTED is treated the same as SYNCING
because then the CL needs to wait for processed FCU and can't reuse the previous status response of the payload.

TODO

  • support full state root validation for sidechains in the tree, I believe @Rjected had a PR for this at some point

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Dec 29, 2023
@mattsse mattsse removed the S-needs-triage This issue needs to be labelled label Dec 29, 2023
@rkrasiuk rkrasiuk self-assigned this Jan 15, 2024
@rkrasiuk rkrasiuk linked a pull request Jan 24, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jan 25, 2024
@michaelsproul
Copy link
Contributor

Yesss hyped for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants