Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a custom error enum for the state root task #13359

Closed
mvares opened this issue Dec 12, 2024 · 5 comments
Closed

Introduce a custom error enum for the state root task #13359

mvares opened this issue Dec 12, 2024 · 5 comments
Labels
A-trie Related to Merkle Patricia Trie implementation C-debt Refactor of code section that is hard to understand or maintain S-stale This issue/PR is stale and will close with no further activity

Comments

@mvares
Copy link
Contributor

mvares commented Dec 12, 2024

Think we should introduce a custom error enum for the state root tas. We seem to abuse the ParallelStateRootError::Other.

Originally posted by @shekhirin in #13356 (comment)

@shekhirin
Copy link
Collaborator

thanks! Do you want me to assign you to this issue?

@shekhirin shekhirin added C-debt Refactor of code section that is hard to understand or maintain A-trie Related to Merkle Patricia Trie implementation labels Dec 13, 2024
@mvares
Copy link
Contributor Author

mvares commented Dec 13, 2024

@shekhirin yes. Btw, where can I create the new enum to these errors?

@mvares
Copy link
Contributor Author

mvares commented Dec 16, 2024

@shekhirin yes. Btw, where can I create the new enum to these errors?

@mattsse what's your opinion?

Copy link
Contributor

github-actions bot commented Jan 7, 2025

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Jan 7, 2025
Copy link
Contributor

This issue was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-trie Related to Merkle Patricia Trie implementation C-debt Refactor of code section that is hard to understand or maintain S-stale This issue/PR is stale and will close with no further activity
Projects
Archived in project
Development

No branches or pull requests

2 participants