Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relaxed SealedBlock in txpool API #13223

Closed
mattsse opened this issue Dec 9, 2024 · 1 comment · Fixed by #13392
Closed

Use relaxed SealedBlock in txpool API #13223

mattsse opened this issue Dec 9, 2024 · 1 comment · Fixed by #13392
Labels
A-sdk Related to reth's use as a library C-enhancement New feature or request S-needs-triage This issue needs to be labelled

Comments

@mattsse
Copy link
Collaborator

mattsse commented Dec 9, 2024

Describe the feature

the update fn currently expects a specific block type

fn on_new_head_block(&self, _new_tip_block: &SealedBlock) {}

we can either solve this introducing a new associated type on the validator trait, or provide the generics on the function.
the latter would be easier but would not allow for type specific validator impls, but this should likely be fine and we can still change it later.

TODO

  • make SealedBlock arg generic over header+body

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Dec 9, 2024
@mattsse mattsse added the A-sdk Related to reth's use as a library label Dec 9, 2024
@stevencartavia
Copy link
Contributor

🙋🏽‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sdk Related to reth's use as a library C-enhancement New feature or request S-needs-triage This issue needs to be labelled
Projects
Archived in project
2 participants