Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --builder.gaslimit cli argument for payload building #13128

Closed
mattsse opened this issue Dec 4, 2024 · 3 comments · Fixed by #13351
Closed

Use --builder.gaslimit cli argument for payload building #13128

mattsse opened this issue Dec 4, 2024 · 3 comments · Fixed by #13351
Assignees
Labels
A-cli Related to the reth CLI C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Dec 4, 2024

Describe the feature

this field is currently unused:

/// Target gas ceiling for built blocks.
#[arg(long = "builder.gaslimit", default_value = "30000000", value_name = "GAS_LIMIT")]
pub max_gas_limit: u64,

we need to wire this to the

pub struct EthereumPayloadBuilder<EvmConfig = EthEvmConfig> {

during setup:

reth_ethereum_payload_builder::EthereumPayloadBuilder::new(evm_config);

for this we should introduce a new Config container type

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Dec 4, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started A-cli Related to the reth CLI and removed S-needs-triage This issue needs to be labelled labels Dec 4, 2024
@mattsse
Copy link
Collaborator Author

mattsse commented Dec 5, 2024

assigned

@rkrasiuk
Copy link
Member

#3233 was not actually resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
3 participants
@mattsse @rkrasiuk and others