Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define OpReceipt #12588

Closed
Tracked by #7649
emhane opened this issue Nov 15, 2024 · 7 comments · Fixed by #13317
Closed
Tracked by #7649

Define OpReceipt #12588

emhane opened this issue Nov 15, 2024 · 7 comments · Fixed by #13317
Assignees
@dastansam
Labels
A-op-reth Related to Optimism and op-reth A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain D-good-first-issue Nice and easy! A great choice to get started

Comments

@emhane
Copy link
Member

emhane commented Nov 15, 2024 •
edited
Loading

Describe the feature

Define OpReceipt which should be a wrapper around the op-alloy type, and should impl reth_primitives_traits::Receipt and reth_primitives_traits::ReceiptExt.

Additional context

No response
@emhane emhane added A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain D-good-first-issue Nice and easy! A great choice to get started labels Nov 15, 2024
@emhane emhane added the A-op-reth Related to Optimism and op-reth label Nov 15, 2024
@emhane emhane mentioned this issue Nov 15, 2024
Closed
@kamuik16
Copy link
Contributor

Describe the feature

Define OpReceipt which should be a wrapper around the op-alloy type, and should impl reth_primitives_traits::Receipt.

Additional context

No response

Which type to take from the op-alloy, there's nothing like OpReceipt in it.

@emhane
Copy link
Member Author

emhane commented Nov 18, 2024

very true @kamuik16 , thanks! The OpReceiptEnvelope wraps ReceiptWithBloom, that's not what we need here. Then please define the type from scratch in reth. It should have the same variants as OpReceiptEnvelope. Eventually we will want to move this new enum to to op-alloy, but to not block the bigger sdk task which this issue is a part of, let's define the type in reth at first and then open an issue, when that's merged, to migrate the type to op-alloy.

@emhane
Copy link
Member Author

emhane commented Nov 19, 2024

are you working on this @kamuik16 ?

@kamuik16
Copy link
Contributor

are you working on this @kamuik16 ?

ahh no, not for now.

@dastansam
Copy link

would like to work on this @emhane

@emhane
Copy link
Member Author

emhane commented Nov 27, 2024

how is it going @dastansam ?

@emhane
Copy link
Member Author

emhane commented Nov 28, 2024

would you like to take this over @edisontim ?

@emhane emhane mentioned this issue Dec 11, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dastansam dastansam

Labels
A-op-reth Related to Optimism and op-reth A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: optimism-specific receipt paradigmxyz/reth
3 participants
@emhane @dastansam @kamuik16