Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progagate TrasactionCompat::Error instead of logging for rpc pubsub. #12456

Closed
lakshya-sky opened this issue Nov 11, 2024 · 2 comments
Closed

Progagate TrasactionCompat::Error instead of logging for rpc pubsub. #12456

lakshya-sky opened this issue Nov 11, 2024 · 2 comments
Labels
A-rpc Related to the RPC implementation C-debt Refactor of code section that is hard to understand or maintain D-good-first-issue Nice and easy! A great choice to get started S-stale This issue/PR is stale and will close with no further activity

Comments

@lakshya-sky
Copy link
Contributor

Describe the feature

See the comment.

same here, this error should be propagated, or, sent as a message i.e. add new variant SubscriptionMessageInner::Error(Box<dyn Error>). please open an issue.

Originally posted by @emhane in #12170 (comment)

Blocked until Pr #12170 is merged

Additional context

No response
@lakshya-sky lakshya-sky added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Nov 11, 2024
@emhane emhane added D-good-first-issue Nice and easy! A great choice to get started C-debt Refactor of code section that is hard to understand or maintain A-rpc Related to the RPC implementation and removed C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Nov 12, 2024
@aroralanuk aroralanuk mentioned this issue Nov 21, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Dec 4, 2024
@mattsse
Copy link
Collaborator

mattsse commented Dec 9, 2024

we have since solved this differently

@mattsse mattsse closed this as completed Dec 9, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-debt Refactor of code section that is hard to understand or maintain D-good-first-issue Nice and easy! A great choice to get started S-stale This issue/PR is stale and will close with no further activity
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(rpc): propagate TransactionCompat::Error instead in rpc/pubsub aroralanuk/reth
3 participants
@lakshya-sky @mattsse @emhane