Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make --engine.experimental default and introduce --engine.legacy instead #11609

Closed
mattsse opened this issue Oct 9, 2024 · 0 comments · Fixed by #11612
Closed

Make --engine.experimental default and introduce --engine.legacy instead #11609

mattsse opened this issue Oct 9, 2024 · 0 comments · Fixed by #11612
Assignees
@shekhirin
Labels
A-cli Related to the reth CLI C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Oct 9, 2024 •
edited
Loading

Describe the feature

TODO

  • keep the if else branches in the launch fn
  • introduce a new --engine.legacy
  • mark --engine.experimantal as clap deprecated

reth/bin/reth/src/main.rs

Lines 22 to 24 in 8396209

/// Enable the engine2 experimental features on reth binary
#[arg(long = "engine.experimental", default_value = "false")]
pub experimental: bool,

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Oct 9, 2024
@mattsse mattsse added A-cli Related to the reth CLI and removed S-needs-triage This issue needs to be labelled labels Oct 9, 2024
@shekhirin shekhirin mentioned this issue Oct 9, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shekhirin shekhirin

Labels
A-cli Related to the reth CLI C-enhancement New feature or request
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(bin): make experimental engine default paradigmxyz/reth
2 participants
@shekhirin @mattsse